From: Tom Lane <tgl@sss.pgh.pa.us>
To: realyota@gmail.com
cc: Joe Conway <mail@joeconway.com>, pgsql-docs@lists.postgresql.org
Subject: Re: dblink_error_message return value
In-reply-to: <153371978486.1298.2091761143788088262@wrigleys.postgresql.org>
References: <153371978486.1298.2091761143788088262@wrigleys.postgresql.org>
Comments: In-reply-to =?utf-8?q?PG_Doc_comments_form?=
 <noreply@postgresql.org>
	message dated "Wed, 08 Aug 2018 09:16:24 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28230.1533743837.1@sss.pgh.pa.us>
Date: Wed, 08 Aug 2018 11:57:17 -0400
Message-ID: <28231.1533743837@sss.pgh.pa.us>
Precedence: bulk

=?utf-8?q?PG_Doc_comments_form?= <noreply@postgresql.org> writes:
> The following documentation comment has been logged on the website:
> Documentation says:

> Return Value
> Returns last error message, or an empty string if there has been no error in
> this connection.
> Which is invalid.
> Actually it returns 'OK' string if no error was raised.

Good catch!  The code's quite clear about it, but the SGML docs need
fixed.

> Secondly
> dblink_is_busy must be first called to make dblink_error_message returns an
> error message. (Tested on 9.6.9)

Meh.  I see what you're getting at here, I think, but that seems like a
completely wrong/misleading statement of the issue.  Joe, can you think of
better phraseology?

			regards, tom lane