Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id EC6A31337B94 for ; Mon, 24 Jan 2011 20:07:04 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 77513-07 for ; Tue, 25 Jan 2011 00:06:58 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id B0F9E133655C for ; Mon, 24 Jan 2011 20:06:56 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p0P06uj8028233; Mon, 24 Jan 2011 19:06:56 -0500 (EST) To: Bruce Momjian cc: PostgreSQL-documentation Subject: Re: Doc reference of contrib modules In-reply-to: <201101242007.p0OK72X22102@momjian.us> References: <201101242007.p0OK72X22102@momjian.us> Comments: In-reply-to Bruce Momjian message dated "Mon, 24 Jan 2011 15:07:02 -0500" Date: Mon, 24 Jan 2011 19:06:56 -0500 Message-ID: <28232.1295914016@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201101/26 X-Sequence-Number: 6318 Bruce Momjian writes: > Now that our /contrib documentation is in our SGML manual, I want to > update our docs to link to the actual contrib module documentation, > rather than just referencing contrib/module_name. We used to have to do > that when we only had READMEs, but now we can do better. > Patch attached, and I have a github branch of this too: This proposed patch seems quite inconsistent. You have removed the term "contrib" in some places and not others. I'm fine with just referring to stuff as "the so-and-so module" without use of the word "contrib", but if that's what we're going to do then all the references should look like that. Also, I see some places where you removed the word contrib *without* turning the reference into a link. I think that's a seriously bad idea, since it leaves the reader with no hint of where to look in our thousand-page-plus manual. regards, tom lane