X-Original-To: pgsql-patches-postgresql.org@postgresql.org
Received: from localhost (mx1.hub.org [200.46.208.251])
	by postgresql.org (Postfix) with ESMTP id 71AA99FB380
	for <pgsql-patches-postgresql.org@postgresql.org>;
	Tue,  1 Aug 2006 23:39:01 -0300 (ADT)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024)
	with ESMTP id 74009-08 for
	<pgsql-patches-postgresql.org@postgresql.org>;
	Tue,  1 Aug 2006 23:38:52 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by postgresql.org (Postfix) with ESMTP id 396CA9FB20B
	for <pgsql-patches@postgresql.org>;
	Tue,  1 Aug 2006 23:38:52 -0300 (ADT)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.13.6/8.13.6) with ESMTP id k722cieE028403;
	Tue, 1 Aug 2006 22:38:44 -0400 (EDT)
To: Gavin Sherry <swm@linuxworld.com.au>
cc: Joe Conway <mail@joeconway.com>, pgsql-patches@postgresql.org
Subject: Re: Values list-of-targetlists patch for comments (was Re: [HACKERS]
	8.2 features?)
In-reply-to: <Pine.LNX.4.58.0608021005220.14057@linuxworld.com.au> 
References: <44B69778.5050104@dunslane.net>
	<ECCAAC0A3182895D3D12B0E8@[172.26.14.247]>
	<44B7ADFC.90205@dunslane.net> <44BC0432.3040509@joeconway.com>
	<44BC661F.80609@joeconway.com> <44BCD06C.3060409@calorieking.com>
	<44BCF1D4.3010807@dunslane.net> <5842.1153246741@sss.pgh.pa.us>
	<44BD8854.9060506@calorieking.com> <15212.1153279954@sss.pgh.pa.us>
	<44BDB2F5.7080003@joeconway.com> <44BEA710.6060700@joeconway.com>
	<23198.1153367887@sss.pgh.pa.us> <44BF0382.2010501@joeconway.com>
	<23454.1153370214@sss.pgh.pa.us> <44BF122F.1080200@joeconway.com>
	<23927.1153373971@sss.pgh.pa.us> <44C00E1E.1000405@joeconway.com>
	<14047.1153442773@sss.pgh.pa.us> <44C4451A.4010906@joeconway.com>
	<11495.1153757531@sss.pgh.pa.us> <44C4F625.2050304@joeconway.com>
	<12029.1153760969@sss.pgh.pa.us> <44CC0A66.6070903@joeconway.com>
	<16429.1154463351@sss.pgh.pa.us> <44CFBC78.2020508@joeconway.com>
	<27359.1154474195@sss.pgh.pa.us>
	<Pine.LNX.4.58.0608021005220.14057@linuxworld.com.au>
Comments: In-reply-to Gavin Sherry <swm@linuxworld.com.au>
	message dated "Wed, 02 Aug 2006 10:05:31 +1000"
Date: Tue, 01 Aug 2006 22:38:44 -0400
Message-ID: <28402.1154486324@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0.182 tagged_above=0 required=5 tests=AWL,
	SPF_HELO_PASS, SPF_PASS
X-Spam-Level: 
X-Archive-Number: 200608/45
X-Sequence-Number: 20561

Gavin Sherry <swm@linuxworld.com.au> writes:
> Is this intentional:

> template1=# values(1), (2);
>  column1
> ---------
>        1
>        2
> (2 rows)

You bet.  VALUES is parallel to SELECT in the SQL grammar, so AFAICS
it should be legal anywhere you can write SELECT.

The basic productions in the spec's grammar are respectively

         <query specification> ::=
              SELECT [ <set quantifier> ] <select list>
                <table expression>

and

         <table value constructor> ::=
              VALUES <row value expression list>

and both of them link into the rest of the grammar here:

         <simple table> ::=
                <query specification>
              | <table value constructor>
              | <explicit table>

There is no construct I can find in the spec grammar that allows
<query specification> but not <table value constructor>.  QED.

Try some stuff like
	DECLARE c CURSOR FOR VALUES ...
	WHERE foo IN (VALUES ...


			regards, tom lane