Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id CDCACB5DC1E for ; Tue, 18 Oct 2011 21:27:55 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 73922-05 for ; Wed, 19 Oct 2011 00:27:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0-rc2 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 846B5B5DC17 for ; Tue, 18 Oct 2011 21:27:48 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p9J0Rl5s028824; Tue, 18 Oct 2011 20:27:47 -0400 (EDT) To: Robert Haas cc: Dmitriy Igrishin , pgsql-docs Subject: Re: PQconninfoParse() In-reply-to: References: <12654.1318692274@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Tue, 18 Oct 2011 20:07:05 -0400" Date: Tue, 18 Oct 2011 20:27:47 -0400 Message-ID: <28823.1318984067@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.404 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RP_MATCHES_RCVD=-0.504 X-Spam-Level: X-Archive-Number: 201110/59 X-Sequence-Number: 7059 Robert Haas writes: > On Sat, Oct 15, 2011 at 11:24 AM, Tom Lane wrote: >> Uh, is that actually a true statement?  I thought the result *did* >> include default values.  That's more or less the point of returning them >> all, after all. > Well, then I'm confused, because you and Dmitriy seem to be saying > opposite things. [ after experimenting with the code ... ] Oh, I had been thinking that PQconndefaults gives the same result as PQconninfoParse with an empty-string argument, but that's not the case. Indeed, the former fills in default values as current values, but the latter does not. The proposed wording change seems reasonable, except that "have a corresponding value" seems a bit vague. Maybe better "have a non-null val field". regards, tom lane