From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
cc: Tatsuo Ishii <ishii@sraoss.co.jp>, pgsql-docs@lists.postgresql.org
Subject: Re: Typo in perform.sgml?
In-reply-to: 
 <CAOBaU_afRuoGf40O0YN_ncZ5L5pEXF8HaUXJ6A_S3XgOJWH5Dw@mail.gmail.com>
References: <20191207.200500.989741087350666720.t-ishii@sraoss.co.jp>
 <CAOBaU_afRuoGf40O0YN_ncZ5L5pEXF8HaUXJ6A_S3XgOJWH5Dw@mail.gmail.com>
Comments: In-reply-to Julien Rouhaud <rjuju123@gmail.com>
	message dated "Sat, 07 Dec 2019 14:01:37 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29010.1575737207.1@sss.pgh.pa.us>
Date: Sat, 07 Dec 2019 11:46:47 -0500
Message-ID: <29011.1575737207@sss.pgh.pa.us>
Precedence: bulk

Julien Rouhaud <rjuju123@gmail.com> writes:
> On Sat, Dec 7, 2019 at 12:05 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>> Around line 904 of perform.sgml
>> "These node types have the ability to discard subnodes which they are
>> able to determine won't contain any records required by the query."
>> 
>> I was not able to parse this. Maybe "that they " is needed after
>> "determine"?

> Agreed.  Also, I'm not a native english speaker either, but the
> "which" sounds weird too.  How about:

> These node types have the ability to discard subnodes for which they
> are able to determine that won't contain any records required by the
> query.

Hm.  A grammar purist would say that the "which" should be "that",
because it's introducing a restrictive clause.  But I think the real
problem here is that "contain" is a crummy choice of verb: the notion
of a plan node "containing" records is what seems weird to me.
I think "produce" might work better.  Also, there's a lot of unnecessary
words here; I think we should be trying to make the sentence shorter
not longer.  How about something like

"These node types will discard subnodes when they detect that a
particular subnode won't produce any records required by the query."

Actually, that whole para could do with a rewrite; whoever wrote
it was obviously not familiar with Strunk & White's dictum
"Omit needless words".

			regards, tom lane