Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j8yFF-0005PC-MQ for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Mar 2020 03:29:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j8yFE-0004m6-08 for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Mar 2020 03:29:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j8yFD-0004lz-Fp for pgsql-hackers@lists.postgresql.org; Tue, 03 Mar 2020 03:29:19 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j8yFA-0003x3-MQ for pgsql-hackers@lists.postgresql.org; Tue, 03 Mar 2020 03:29:18 +0000 Received: from hnk.local (p1752128-ipbf1308funabasi.chiba.ocn.ne.jp [123.218.229.128]) by oss.nttdata.com (Postfix) with ESMTPSA id B001260242; Tue, 3 Mar 2020 12:29:12 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.101.5 at oss.nttdata.com Subject: Re: First WAL segment file that initdb creates To: David Zhang , pgsql-hackers@lists.postgresql.org Cc: Fujii Masao References: <158205760364.26210.17325175504060984319.pgcf@coridan.postgresql.org> From: Fujii Masao Message-ID: <2933f1ae-3fc6-cdac-d7a0-e4566a90c7d4@oss.nttdata.com> Date: Tue, 3 Mar 2020 12:29:12 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <158205760364.26210.17325175504060984319.pgcf@coridan.postgresql.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/02/19 5:26, David Zhang wrote: > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Documentation: tested, passed > > The issue has been verified using below steps: > 1. $ initdb -D /home/test/PG122DATA/data > 2. $ ls -l /home/test/PG122DATA/data/pg_wal/ > total 16388 > -rw------- 1 test test 16777216 Feb 18 12:07 000000010000000000000001 > drwx------ 2 test test 4096 Feb 18 12:07 archive_status > > The first WAL segment file created by initdb is "000000010000000000000001", not "000000010000000000000000". Thanks for the test! I pushed the patch. Regards, -- Fujii Masao NTT DATA CORPORATION Advanced Platform Technology Group Research and Development Headquarters