Message-ID: <293903c1f00f9b5053c0aa388ddc2850ae537f33.camel@cybertec.at>
Subject: Re: Document target_role param of ALTER DEFAULT PRIVILEGES
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Jordi =?ISO-8859-1?Q?Guti=E9rrez?= Hermoso <jordigh@octave.org>,
	pgsql-docs@lists.postgresql.org
Date: Thu, 18 Feb 2021 08:16:13 +0100
In-Reply-To: <72652d72e1816bfc3c05d40f9e0e0373d07823c8.camel@octave.org>
References: <72652d72e1816bfc3c05d40f9e0e0373d07823c8.camel@octave.org>
Content-Type: multipart/mixed; boundary="=-XbUEmEvjUU0EADE5lJxU"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Precedence: bulk


--=-XbUEmEvjUU0EADE5lJxU
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On Wed, 2021-02-17 at 15:08 -0500, Jordi Gutiérrez Hermoso wrote:
> I just had a confusing moment trying to figure out why my roles
> weren't creating tables the way I was expecting them to. I didn't
> understand what the `target_role` parameter did. No matter how I try
> to read this page, I can't see an explanation for that parameter:
> 
> https://www.postgresql.org/docs/current/sql-alterdefaultprivileges.html
> 
> I propose an explanation like the following be added to the
> `target_role` parameter:
> 
>     This is the role that will create objects with altered default
>     privileges. Note that changes in default privileges aren't
>     inherited, so altering the default privileges of created objects
>     for a parent role will not change the default privileges of
>     objects created by inherited roles.

+1.  I cannot count the number of times I have seen people confused by that.

Suggested patch attached.

Yours,
Laurenz Albe

--=-XbUEmEvjUU0EADE5lJxU
Content-Disposition: attachment;
	filename="0001-Clarify-docs-for-ALTER-DEFAULT-PRIVILEGES.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch;
 name="0001-Clarify-docs-for-ALTER-DEFAULT-PRIVILEGES.patch";
	charset="UTF-8"

RnJvbSA2Y2E3YWQ4OWIwNmM2NWQ1NzRhNWU5ZGE4MTkyYTE0NDU4ODYzY2I2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogVGh1LCAxOCBGZWIgMjAyMSAwODoxNDo1NSArMDEwMApTdWJqZWN0OiBbUEFUQ0hd
IENsYXJpZnkgZG9jcyBmb3IgQUxURVIgREVGQVVMVCBQUklWSUxFR0VTCk1JTUUtVmVyc2lvbjog
MS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z
ZmVyLUVuY29kaW5nOiA4Yml0CgpTaW5jZSB0aGlzIGlzIG9mdGVuIGEgY2F1c2Ugb2YgY29uZnVz
aW9uLCBkb2N1bWVudCB0aGF0IHRoZQpkZWZhdWx0IHByaXZpbGVnZXMgd2lsbCBvbmx5IGJlIGFw
cGxpZWQgdG8gb2JqZWN0cyBjcmVhdGVkCmJ5IHRoZSB0YXJnZXQgcm9sZS4KClN1Z2dlc3RlZCBi
eSBKb3JkaSBHdXRpw6lycmV6IEhlcm1vc28uCgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5l
cy9tLzcyNjUyZDcyZTE4MTZiZmMzYzA1ZDQwZjllMGUwMzczZDA3ODIzYzguY2FtZWxAb2N0YXZl
Lm9yZwotLS0KIGRvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfZGVmYXVsdF9wcml2aWxlZ2VzLnNnbWwg
fCA3ICsrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQg
YS9kb2Mvc3JjL3NnbWwvcmVmL2FsdGVyX2RlZmF1bHRfcHJpdmlsZWdlcy5zZ21sIGIvZG9jL3Ny
Yy9zZ21sL3JlZi9hbHRlcl9kZWZhdWx0X3ByaXZpbGVnZXMuc2dtbAppbmRleCBmMWQ1NGY1YWEz
Li4wNDhkYmM5ZmUyIDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL2FsdGVyX2RlZmF1bHRf
cHJpdmlsZWdlcy5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfZGVmYXVsdF9wcml2
aWxlZ2VzLnNnbWwKQEAgLTEzOCw2ICsxMzgsMTMgQEAgUkVWT0tFIFsgR1JBTlQgT1BUSU9OIEZP
UiBdCiAgICAgIDxwYXJhPgogICAgICAgVGhlIG5hbWUgb2YgYW4gZXhpc3Rpbmcgcm9sZSBvZiB3
aGljaCB0aGUgY3VycmVudCByb2xlIGlzIGEgbWVtYmVyLgogICAgICAgSWYgPGxpdGVyYWw+Rk9S
IFJPTEU8L2xpdGVyYWw+IGlzIG9taXR0ZWQsIHRoZSBjdXJyZW50IHJvbGUgaXMgYXNzdW1lZC4K
KworICAgICAgVGhlIHByaXZpbGVnZXMgZGVmaW5lZCBpbgorICAgICAgPHJlcGxhY2VhYmxlIGNs
YXNzPSJwYXJhbWV0ZXIiPmFiYnJldmlhdGVkX2dyYW50X29yX3Jldm9rZTwvcmVwbGFjZWFibGU+
CisgICAgICB3aWxsIG9ubHkgYmUgc2V0IG9uIG9iamVjdHMgY3JlYXRlZCBieSA8cmVwbGFjZWFi
bGU+dGFyZ2V0X3JvbGU8L3JlcGxhY2VhYmxlPi4KKyAgICAgIFRoaXMgZG9lcyBub3QgZXh0ZW5k
IHRvIHJvbGUgbWVtYmVycy4gIElmIHRoZXJlIGFyZSBzZXZlcmFsIHJvbGVzIHRoYXQgY291bGQK
KyAgICAgIGNyZWF0ZSBvYmplY3RzLCB5b3UgbWF5IGhhdmUgdG8gcnVuIDxjb21tYW5kPkFMVEVS
IERFRkFVTFQgUFJJVklMRUdFUzwvY29tbWFuZD4KKyAgICAgIGZvciBlYWNoIG9mIHRoZW0uCiAg
ICAgIDwvcGFyYT4KICAgICA8L2xpc3RpdGVtPgogICAgPC92YXJsaXN0ZW50cnk+Ci0tIAoyLjI2
LjIKCg==


--=-XbUEmEvjUU0EADE5lJxU--