Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYtW1-0007qW-SA for pgsql-docs@arkaria.postgresql.org; Wed, 13 May 2020 15:41:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jYtW0-0003bS-D2 for pgsql-docs@arkaria.postgresql.org; Wed, 13 May 2020 15:41:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYtW0-0003bL-72 for pgsql-docs@lists.postgresql.org; Wed, 13 May 2020 15:41:48 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYtVx-0007gJ-HD for pgsql-docs@postgresql.org; Wed, 13 May 2020 15:41:47 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 04DFffgb002962; Wed, 13 May 2020 11:41:41 -0400 From: Tom Lane To: Fujii Masao cc: pgsql-docs@postgresql.org Subject: Re: The order of columns about WAL activity in pg_stat_statements In-reply-to: References: Comments: In-reply-to Fujii Masao message dated "Thu, 14 May 2020 00:11:22 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2960.1589384501.1@sss.pgh.pa.us> Date: Wed, 13 May 2020 11:41:41 -0400 Message-ID: <2961.1589384501@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Fujii Masao writes: > In pg_stat_statements docs, the columns about WAL activity are put > in the table in the order of wal_bytes, wal_records and wal_fpi. But > in the definition of pg_stat_statements view, wal_bytes is put last. > So I think that it's better to reorder those columns in a consistent > with the view definition. Patch attached. Thought? I already fixed this in my pending patch to restructure the catalog docs [1]. regards, tom lane [1] https://www.postgresql.org/message-id/14810.1589128043%40sss.pgh.pa.us