Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229]) by mail.postgresql.org (Postfix) with ESMTP id C81571B505EF for ; Wed, 14 Mar 2012 11:22:17 -0300 (ADT) Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1S7p5f-0000zL-1j for pgsql-docs@postgresql.org; Wed, 14 Mar 2012 14:22:16 +0000 Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id q2EELuH3029896; Wed, 14 Mar 2012 10:21:56 -0400 (EDT) To: John Lumby cc: pgsql-docs@postgresql.org Subject: Re: Cannot build docs on Ubuntu 10.04? In-reply-to: References: Comments: In-reply-to John Lumby message dated "Wed, 14 Mar 2012 09:25:19 -0400" Date: Wed, 14 Mar 2012 10:21:55 -0400 Message-ID: <29895.1331734915@sss.pgh.pa.us> From: Tom Lane X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201203/4 X-Sequence-Number: 7203 John Lumby writes: > On 12-01-2012 17:28, Josh Berkus wrote: > I wonder if everyone noticed that the postgres sgml makefile is looking for the script in /bin > (see Josh's append) That means that configure failed to find it, and failed to determine a setting for DOCBOOKSTYLE as well. > I think this line in > postgresql-9.1.3/doc/src/sgml/Makefile > COLLATEINDEX = $(DOCBOOKSTYLE)/bin/collateindex.pl > could be improved  -  maybe should read > COLLATEINDEX = `which collateindex.pl` No, that would not be an improvement. If collateindex.pl were in your PATH, then configure would have found it (cf PGAC_PATH_COLLATEINDEX), and so COLLATEINDEX would be set and we'd not be here at all. Maybe the Makefile should just error out if COLLATEINDEX isn't set, rather than trying a "fallback" value that configure has already determined isn't going to work. regards, tom lane