Content-Type: multipart/mixed; boundary="------------m3XuG5crnnnse1szxpcNr4r7"
Message-ID: <29fd8017-7f4a-4d58-8649-4847c558c8a7@oss.nttdata.com>
Date: Fri, 18 Jul 2025 12:33:36 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Document reopen of output file via SIGHUP in pg_recvlogical
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
References: <0977fc4f-1523-4ecd-8a0e-391af4976367@oss.nttdata.com>
 <CAOzEurQ9fZKw+Ydr2=LUBr=XCmXzjA+u=xmKjj=7bA=BGNharA@mail.gmail.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <CAOzEurQ9fZKw+Ydr2=LUBr=XCmXzjA+u=xmKjj=7bA=BGNharA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/29fd8017-7f4a-4d58-8649-4847c558c8a7%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------m3XuG5crnnnse1szxpcNr4r7
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable


On 2025/07/18 11:35, Shinya Kato wrote:
> On Thu, Jul 10, 2025 at 4:48=E2=80=AFPM Fujii Masao <masao.fujii@oss.nt=
tdata.com> wrote:
>>
>> Hi,
>>
>> pg_recvlogical continuously writes to the file specified with the --fi=
le option,
>> which means the output file can grow indefinitely. To manage file size=
,
>> some users may want to rotate the output periodically.
>>
>> While reviewing the source code to find the way to rotate the file, I =
noticed
>> that pg_recvlogical reopens the output file when it receives a SIGHUP =
signal.
>> This makes file rotation possible: we can rename the current output fi=
le and
>> then send a SIGHUP to pg_recvlogical, which will close the renamed fil=
e and
>> open a new one with the same original name.
>>
>> This is a useful feature, but it's currently undocumented. So I'd like=
 to
>> apply the attached patch that adds this information to the documentati=
on.
>> Thought?
>=20
> Agreed.
> I have confirmed the behavior and I think it should be documented.
>=20
> Your patch looks good, except that you should use "specified by"
> instead of "given with" to be consistent with the other documents.

Thanks for the review! I've updated the patch as suggested.
The revised version is attached.

Unless there are any objections, I will commit and back-patch it to v13.

Regards,

--=20
Fujii Masao
NTT DATA Japan Corporation

--------------m3XuG5crnnnse1szxpcNr4r7
Content-Type: text/plain; charset=UTF-8;
 name="v2-0001-doc-Document-reopen-of-output-file-via-SIGHUP-in-.patch"
Content-Disposition: attachment;
 filename*0="v2-0001-doc-Document-reopen-of-output-file-via-SIGHUP-in-.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBiYTMwZmVhNDVmMmY3ZDA4ZDhmZTViYTQ1MWI5YzY1OGEyOGYxZWUxIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IEZyaSwgMTggSnVsIDIwMjUgMTI6MjE6MTEgKzA5MDAKU3ViamVjdDogW1BB
VENIIHYyXSBkb2M6IERvY3VtZW50IHJlb3BlbiBvZiBvdXRwdXQgZmlsZSB2aWEgU0lHSFVQ
IGluCiBwZ19yZWN2bG9naWNhbC4KCldoZW4gcGdfcmVjdmxvZ2ljYWwgcmVjZWl2ZXMgYSBT
SUdIVVAgc2lnbmFsLCBpdCBjbG9zZXMgdGhlIGN1cnJlbnQKb3V0cHV0IGZpbGUgYW5kIHJl
b3BlbnMgYSBuZXcgb25lLiBUaGlzIGlzIHVzZWZ1bCBzaW5jZSBpdCBhbGxvd3MgdXMgdG8K
cm90YXRlIHRoZSBvdXRwdXQgZmlsZSBieSByZW5hbWluZyB0aGUgY3VycmVudCBmaWxlIGFu
ZCBzZW5kaW5nIGEgU0lHSFVQLgoKVGhpcyBiZWhhdmlvciB3YXMgcHJldmlvdXNseSB1bmRv
Y3VtZW50ZWQuIFRoaXMgY29tbWl0IGFkZHMKdGhlIG1pc3NpbmcgZG9jdW1lbnRhdGlvbi4K
CkJhY2stcGF0Y2ggdG8gYWxsIHN1cHBvcnRlZCB2ZXJzaW9ucy4KCkF1dGhvcjogRnVqaWkg
TWFzYW8gPG1hc2FvLmZ1amlpQGdtYWlsLmNvbT4KUmV2aWV3ZWQtYnk6IFNoaW55YSBLYXRv
IDxzaGlueWExMS5rYXRvQGdtYWlsLmNvbT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3Iu
ZXMvbS8wOTc3ZmM0Zi0xNTIzLTRlY2QtOGEwZS0zOTFhZjQ5NzYzNjdAb3NzLm50dGRhdGEu
Y29tCkJhY2twYXRjaC10aHJvdWdoOiAxMwotLS0KIGRvYy9zcmMvc2dtbC9yZWYvcGdfcmVj
dmxvZ2ljYWwuc2dtbCB8IDEwICsrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNl
cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZWN2bG9naWNh
bC5zZ21sIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZWN2bG9naWNhbC5zZ21sCmluZGV4IGY2
ODE4MjI2NmE5Li4yNjNlYmRlZWFiNCAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3JlZi9w
Z19yZWN2bG9naWNhbC5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYvcGdfcmVjdmxvZ2lj
YWwuc2dtbApAQCAtNTMsNiArNTMsMTYgQEAgUG9zdGdyZVNRTCBkb2N1bWVudGF0aW9uCiAg
ICAoPGtleWNvbWJvIGFjdGlvbj0ic2ltdWwiPjxrZXljYXA+Q29udHJvbDwva2V5Y2FwPjxr
ZXljYXA+Qzwva2V5Y2FwPjwva2V5Y29tYm8+KQogICAgb3IgPHN5c3RlbWl0ZW0+U0lHVEVS
TTwvc3lzdGVtaXRlbT4gc2lnbmFsLgogICA8L3BhcmE+CisKKyAgPHBhcmE+CisgICBXaGVu
IDxhcHBsaWNhdGlvbj5wZ19yZWN2bG9naWNhbDwvYXBwbGljYXRpb24+IHJlY2VpdmVzCisg
ICBhIDxzeXN0ZW1pdGVtPlNJR0hVUDwvc3lzdGVtaXRlbT4gc2lnbmFsLCBpdCBjbG9zZXMg
dGhlIGN1cnJlbnQgb3V0cHV0IGZpbGUKKyAgIGFuZCBvcGVucyBhIG5ldyBvbmUgdXNpbmcg
dGhlIGZpbGVuYW1lIHNwZWNpZmllZCBieQorICAgdGhlIDxvcHRpb24+LS1maWxlPC9vcHRp
b24+IG9wdGlvbi4gIFRoaXMgYWxsb3dzIHVzIHRvIHJvdGF0ZQorICAgdGhlIG91dHB1dCBm
aWxlIGJ5IGZpcnN0IHJlbmFtaW5nIHRoZSBjdXJyZW50IGZpbGUgYW5kIHRoZW4gc2VuZGlu
ZworICAgYSA8c3lzdGVtaXRlbT5TSUdIVVA8L3N5c3RlbWl0ZW0+IHNpZ25hbCB0bworICAg
PGFwcGxpY2F0aW9uPnBnX3JlY3Zsb2dpY2FsPC9hcHBsaWNhdGlvbj4uCisgIDwvcGFyYT4K
ICA8L3JlZnNlY3QxPgogCiAgPHJlZnNlY3QxPgotLSAKMi40OS4wCgo=

--------------m3XuG5crnnnse1szxpcNr4r7--