Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: Postgres upgrade does not mention requirement to have only 1 user
From: Charlie Hayes <ce.ceo@cybercoment.com>
In-Reply-To: <eced44db1c20de9cdce0dcd6b7922a113d3728a2.camel@cybertec.at>
Date: Tue, 26 Jan 2021 11:16:20 -0600
Cc: pgsql-docs@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <2AA2F2BC-FD29-49ED-BCF1-937E4192E54F@cybercoment.com>
References: <161164427375.4070.1378381620788426246@wrigleys.postgresql.org>
 <eced44db1c20de9cdce0dcd6b7922a113d3728a2.camel@cybertec.at>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Precedence: bulk

It may say =E2=80=9Cin the new cluster=E2=80=9D but it was not clear to =
me if that was =E2=80=9Cin the new cluster (before the upgrade =
starts)=E2=80=9D or =E2=80=9Cin the new cluster (after the upgrade =
completes)=E2=80=9D

In hind sight everything makes sense, but in the present it was very =
confusing.

-Charlie

> On Jan 26, 2021, at 2:39 AM, Laurenz Albe <laurenz.albe@cybertec.at> =
wrote:
>=20
> On Tue, 2021-01-26 at 06:57 +0000, PG Doc comments form wrote:
>> Page: https://www.postgresql.org/docs/13/pgupgrade.html
>> Description:
>>=20
>> During the pg_upgrade process, a check is run to make sure
>> pg_catalog.pg_roles has only a single non pg_* user, typically this =
is just
>> 'postgres'. If this check fails, the error message is "Only the =
install user
>> can be defined in the new cluster."; This message implies the user =
executing
>> pg_upgrade must match the the rolsuper in pg_catalog.pg_roles.
>>=20
>> There's no indication in the documentation that the user table must =
be
>> flushed of all but the one user, nor does it prescribe a method to =
move
>> forward. The error message is not helpful; I only figured it out by =
finding
>> and reading the postgres source code.
>=20
> The error message says "in the new cluster".
>=20
> The documentation says, "Initialize the new PostgreSQL cluster" and =
that there
> is no need to start the cluster.  That is a pretty strong indication =
that it
> is not necessary to create any objects there.
>=20
> But perhaps it would not harm to be more explicit and add something =
like
> that:
>=20
> "Do not create and users, tablespaces or other objects on the new =
cluster."
>=20
> Yours,
> Laurenz Albe
>=20