Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1snzKK-007QhJ-Ph
	for pgsql-docs@arkaria.postgresql.org; Tue, 10 Sep 2024 11:46:34 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1snzKK-00BzqF-7S
	for pgsql-docs@arkaria.postgresql.org; Tue, 10 Sep 2024 11:46:32 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <o.sibiryakov@postgrespro.ru>)
	id 1snzKJ-00Bzq7-Qc
	for pgsql-docs@lists.postgresql.org; Tue, 10 Sep 2024 11:46:31 +0000
Received: from mail.postgrespro.ru ([93.174.131.139])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <o.sibiryakov@postgrespro.ru>)
	id 1snzKC-000Srd-0L
	for pgsql-docs@lists.postgresql.org; Tue, 10 Sep 2024 11:46:30 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mx2023; t=1725968784;
	bh=duBwe7OY8lAdQGb0RA3olxalhksS5Zt0gU22ZfTMhYY=;
	h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:
	 In-Reply-To:From;
	b=7inyuFr6bsIt6/yAdMAXgYhWAjDJZaOB/xSxTFBDDYWRb6I7TDxWbBGcHk/RcNTU3
	 L56E3bisgKh2naFJsTS7qfl40HJvY3QQLNiv+Gxm6DQBnVBhTS9wPNilBdOXuiBELg
	 XSm/sMaAJ9MYweTYW5aXHFvtUNE3IZhABzHmoDf/LKb/IjSqH3yZMynalz6ej0JX1e
	 SqyPddEgCUy/z+k0gFaiFYe0Qg7oburzR+UkDkluyrabLPfRyzZzbpAWe07D0BkNqn
	 mzD9rVAiec/iCabFZ89LxAFe5/bRSGB7A5BPEhxf1jZqus/1620wIMsY8FJuuoOR9p
	 8lXuWNzEHHgFQ==
Received: from [10.4.14.56] (unknown [93.174.131.141])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest
 SHA256)
	(Client did not present a certificate)
	(Authenticated sender: o.sibiryakov@postgrespro.ru)
	by mail.postgrespro.ru (Postfix/587) with ESMTPSA id 10DAA6038A;
	Tue, 10 Sep 2024 14:46:24 +0300 (MSK)
Message-ID: <2a9455d8-2938-4346-93bc-2eb02b6261e0@postgrespro.ru>
Date: Tue, 10 Sep 2024 14:46:23 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Documentation improvement patch
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-docs@lists.postgresql.org
References: <b7d0a03c-107e-48c7-a5c9-2c6f73cdf78f@postgrespro.ru>
 <BAB3A99C-66CA-4377-9D19-71763045C9A4@yesql.se>
Content-Language: en-US
From: Oleg Sibiryakov <o.sibiryakov@postgrespro.ru>
In-Reply-To: <BAB3A99C-66CA-4377-9D19-71763045C9A4@yesql.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-KSMG-AntiPhishing: NotDetected
X-KSMG-AntiSpam-Interceptor-Info: not scanned
X-KSMG-AntiSpam-Status: not scanned, disabled by settings
X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854,
 bases: 2024/09/10 10:45:00 #26551040
X-KSMG-AntiVirus-Status: NotDetected, skipped
X-KSMG-LinksScanning: not scanned, disabled by settings
X-KSMG-Message-Action: skipped
X-KSMG-Rule-ID: 1
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/2a9455d8-2938-4346-93bc-2eb02b6261e0%40postgrespro.ru>
Precedence: bulk

Thank you for your feedback.

1. Since we do not want to use <literal> here, I suggest we hyphenate it 
as "built-in". What's your take on it?
2. Leaving not-null is fine.

--
Oleg Sibiryakov

On 06.09.2024 16:20, Daniel Gustafsson wrote:
>> On 5 Sep 2024, at 11:33, Oleg Sibiryakov <o.sibiryakov@postgrespro.ru> wrote:
>>
>> Dear all,
>> I have prepared a patch containing some minor inconsistencies in the documentation. Please, take a look.
>> The inconsistencies were noticed by: Ekaterina Kiryanova, Elena Indrupskaya, Maxim Yablokov, Anna Uraskova, Elena Karavaeva, and me.
>> We will be looking forward to your feedback.
>> The patch shall be applied to the REL_17_STABLE branch.
> Most of these seem fine, but I need another read-through to digest them fully.
> Just a few small comments:
>
> -        Specifies the builtin provider locale for the database default
> -        collation order and character classification, overriding the setting
> -        <xref linkend="create-database-locale"/>.  The <link
> +        Specifies the <literal>builtin</literal> provider locale for the database
> +        default collation order and character classification, overriding the
> +        setting <xref linkend="create-database-locale"/>.  The <link
> and
> -        Specifies the locale name when the builtin provider is used. Locale support
> -        is described in <xref linkend="locale"/>.
> +        Specifies the locale name when the <literal>builtin</literal> provider
> +        is used. Locale support is described in <xref linkend="locale"/>.
>
>
> I don't think this use of "builtin" refers to the config value but rather the
> type of locale, so I think it's correct to not use <literal> here.
>
>
> -    for not-null constraints at all, so they are not
> +    for <literal>NOT NULL</literal> constraints at all, so they are not
>
> This seems mostly to be a question of taste, I don't think not-null is
> incorrect here.
>
> --
> Daniel Gustafsson
>
>
>