Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj09C-0004fO-A7 for pgsql-docs@arkaria.postgresql.org; Tue, 18 May 2021 13:52:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lj09B-0005G9-7h for pgsql-docs@arkaria.postgresql.org; Tue, 18 May 2021 13:52:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj09B-0005G1-1t for pgsql-docs@lists.postgresql.org; Tue, 18 May 2021 13:52:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj099-00054N-00 for pgsql-docs@lists.postgresql.org; Tue, 18 May 2021 13:52:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 14IDqRci3079731; Tue, 18 May 2021 09:52:27 -0400 From: Tom Lane To: tanghy.fnst@fujitsu.com cc: pgsql-docs@lists.postgresql.org Subject: Re: typo in doc for "Miscellaneous Coding Conventions" In-reply-to: <162131484867.24518.3990274826700661694@wrigleys.postgresql.org> References: <162131484867.24518.3990274826700661694@wrigleys.postgresql.org> Comments: In-reply-to PG Doc comments form message dated "Tue, 18 May 2021 05:14:08 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3079729.1621345947.1@sss.pgh.pa.us> Date: Tue, 18 May 2021 09:52:27 -0400 Message-ID: <3079730.1621345947@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk PG Doc comments form writes: > small fix in description at [1] as follows > -If that were not done interrupted code that's currently inspecting errno > might see the wrong value. > +If that was not done interrupted code that's currently inspecting errno > might see the wrong value. The existing text is perfectly good English; your change makes it less so. I'm afraid it's been too many years since high school English for me to remember the exact grammatical term for this, but "were not" is typical usage when stating a contrary-to-fact hypothetical. regards, tom lane