From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: Kirk Parker <khp@equatoria.us>, pgsql-docs@lists.postgresql.org
Subject: Re: Typo in PL/pgSQL trigger Example 43.4?
In-reply-to: 
 <CAKFQuwZW2qTAavt8R1c20wW_OOn9YZ9Eoz4oc8jy3+Y2en0keQ@mail.gmail.com>
References: 
 <CAA_1=909ZR0ofmS5_JKonYwf+AdrU4_wojm5ckaB50s2EibzpQ@mail.gmail.com>
 <ZSBgYzT3vh7YOsew@momjian.us>
 <CANwZ8rmN_Eb0h0hoMRS8Feftaik0z89PxVsKg+cP+PctuOq=Qg@mail.gmail.com>
 <CAKFQuwZW2qTAavt8R1c20wW_OOn9YZ9Eoz4oc8jy3+Y2en0keQ@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Sat, 07 Oct 2023 11:15:34 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3179620.1696710121.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 07 Oct 2023 16:22:01 -0400
Message-ID: <3179621.1696710121@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3179621.1696710121%40sss.pgh.pa.us>
Precedence: bulk

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Sat, Oct 7, 2023 at 11:11=E2=80=AFAM Kirk Parker <khp@equatoria.us> w=
rote:
>> INSERT INTO emp_audit SELECT 'D', now(), user, OLD.*; -- <=3D ARGUMENT =
IN QUESTION
>> The emp_audit table has a column named 'userid', which in actual usage
>> (next-to-last line quoted) is populated by 'user' which seems undefined=
 in
>> the context.  Was that intended to be 'current_user', or am I missing
>> something?

> user is a valid pseudo-function:
> https://www.postgresql.org/docs/current/functions-info.html#FUNCTIONS-IN=
FO-SESSION

Yeah, either way has the same result.  However, I wonder if we should
change this example to use current_user for clarity.  It does look
more like it's intended to be a variable or column reference than
a built-in function.

			regards, tom lane