From: Tobias Bussmann <t.bussmann@gmx.net>
Message-Id: <3232E7C8-8182-403A-9BF1-06D23410BAEF@gmx.net>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_FAE63F1A-851B-4CFA-BEE9-CBEC09371265"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: Docs for Generated Columns
Date: Sun, 26 May 2019 22:42:15 +0200
In-Reply-To: <9997d7e0-b0d9-1ec5-365d-153b58ad533e@joeconway.com>
Cc: Joe Conway <mail@joeconway.com>
To: pgsql-docs@lists.postgresql.org
References: <071F9108-0335-4309-ACD3-262AF04A1817@gmx.net>
 <9997d7e0-b0d9-1ec5-365d-153b58ad533e@joeconway.com>
Precedence: bulk


--Apple-Mail=_FAE63F1A-851B-4CFA-BEE9-CBEC09371265
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 24.05.2019 14:21, Joe Conway <mail@joeconway.com> wrote:
>> The column cannot be written to, and when read the result of the
>> specified expression will be returned.
> That sounds reasonable to me.

Thank you for confirmation and review. Please find attached my proposed =
little doc patch for this issue.

Tobias


--Apple-Mail=_FAE63F1A-851B-4CFA-BEE9-CBEC09371265
Content-Disposition: attachment;
	filename=001-reword-gen-col-docs.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="001-reword-gen-col-docs.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/doc/src/sgml/ref/create_foreign_table.sgml b/doc/src/sgml/ref=
/create_foreign_table.sgml
index 5db15eb73e..25d2f09ed2 100644
=2D-- a/doc/src/sgml/ref/create_foreign_table.sgml
+++ b/doc/src/sgml/ref/create_foreign_table.sgml
@@ -268,8 +268,8 @@ CHECK ( <replaceable class=3D"parameter">expression</r=
eplaceable> ) [ NO INHERIT ]
     <listitem>
      <para>
       This clause creates the column as a <firstterm>generated
-      column</firstterm>.  The column cannot be written to, and when read=
 it
-      will be computed from the specified expression.
+      column</firstterm>.  The column cannot be written to, and when read=
 the
+      result of the specified expression will be returned.
      </para>

      <para>
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_=
table.sgml
index 44a61ef99e..8e1bfe4d78 100644
=2D-- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -813,8 +813,8 @@ WITH ( MODULUS <replaceable class=3D"parameter">numeri=
c_literal</replaceable>, REM
     <listitem>
      <para>
       This clause creates the column as a <firstterm>generated
-      column</firstterm>.  The column cannot be written to, and when read=
 it
-      will be computed from the specified expression.
+      column</firstterm>.  The column cannot be written to, and when read=
 the
+      result of the specified expression will be returned.
      </para>

      <para>

--Apple-Mail=_FAE63F1A-851B-4CFA-BEE9-CBEC09371265--