pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedkilobyte unit spelled "K bytes"
5+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2019-09-03 4e72a8e11e Doc: Replace mention to "K bytes" by "kilobytes" in textsearch.sgml
* kilobyte unit spelled "K bytes"
@ 2019-08-29 10:15 Daniel Gustafsson <daniel@yesql.se>
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Gustafsson @ 2019-08-29 10:15 UTC (permalink / raw)
To: Pg Docs <pgsql-docs@lists.postgresql.org>
In the documentation there is a single instance of “K bytes” being used to
denote kilobytes (kB or kilobyte used everywhere else), which isn’t really
correct as the k should be lowercased. The attached diff fixes this to make it
consistent with the rest of the documentation. I opted for kilobytes rather
than kB to match the rest of the document in question.
cheers ./daniel
Attachments:
kilobytes.diff (application/octet-stream, 587B) download
diff --git a/doc/src/sgml/textsearch.sgml b/doc/src/sgml/textsearch.sgml
index 196558b440..3f00ae3bd9 100644
--- a/doc/src/sgml/textsearch.sgml
+++ b/doc/src/sgml/textsearch.sgml
@@ -3915,7 +3915,7 @@ Parser: "pg_catalog.default"
text search features are:
<itemizedlist spacing="compact" mark="bullet">
<listitem>
- <para>The length of each lexeme must be less than 2K bytes</para>
+ <para>The length of each lexeme must be less than 2 kilobytes</para>
</listitem>
<listitem>
<para>The length of a <type>tsvector</type> (lexemes + positions) must be
* Re: kilobyte unit spelled "K bytes"
@ 2019-08-30 00:14 Michael Paquier <michael@paquier.xyz>
parent: Daniel Gustafsson <daniel@yesql.se>
1 sibling, 0 replies; 5+ messages in thread
From: Michael Paquier @ 2019-08-30 00:14 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
On Thu, Aug 29, 2019 at 12:15:51PM +0200, Daniel Gustafsson wrote:
> In the documentation there is a single instance of “K bytes” being used to
> denote kilobytes (kB or kilobyte used everywhere else), which isn’t really
> correct as the k should be lowercased. The attached diff fixes this to make it
> consistent with the rest of the documentation. I opted for kilobytes rather
> than kB to match the rest of the document in question.
From doc/, we have that:
$ git grep kB | wc -l
40
$ git grep kilobytes | wc -l
21
Now, your choice makes sense to me, because 4 lines down the maximum
refers to "megabyte". Do others have opinions to offer?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: kilobyte unit spelled "K bytes"
@ 2019-08-30 00:34 Nikolay Samokhvalov <samokhvalov@gmail.com>
parent: Daniel Gustafsson <daniel@yesql.se>
1 sibling, 1 reply; 5+ messages in thread
From: Nikolay Samokhvalov @ 2019-08-30 00:34 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
Related:
https://www.postgresql.org/message-id/flat/20160730001838.GA22405%40momjian.us#ef946043c336d66e717e0...
Although, 3 years passed since then. I constantly see "kiB", "MiB", etc in
many discussions. And some very popular programs already migrated to it.
For example, in Linux, "top" uses "KiB Mem", "KiB Swap".
On Thu, Aug 29, 2019 at 3:16 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> In the documentation there is a single instance of “K bytes” being used to
> denote kilobytes (kB or kilobyte used everywhere else), which isn’t really
> correct as the k should be lowercased. The attached diff fixes this to
> make it
> consistent with the rest of the documentation. I opted for kilobytes
> rather
> than kB to match the rest of the document in question.
>
> cheers ./daniel
>
>
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: kilobyte unit spelled "K bytes"
@ 2019-08-30 08:37 Daniel Gustafsson <daniel@yesql.se>
parent: Nikolay Samokhvalov <samokhvalov@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Gustafsson @ 2019-08-30 08:37 UTC (permalink / raw)
To: Nikolay Samokhvalov <samokhvalov@gmail.com>; +Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
> On 30 Aug 2019, at 02:34, Nikolay Samokhvalov <samokhvalov@gmail.com> wrote:
>
> Related: https://www.postgresql.org/message-id/flat/20160730001838.GA22405%40momjian.us#ef946043c336d66e717e0... <https://www.postgresql.org/message-id/flat/20160730001838.GA22405@momjian.us#ef946043c336d66e717e0e6...;
>
> Although, 3 years passed since then. I constantly see "kiB", "MiB", etc in many discussions. And some very popular programs already migrated to it.
Not sure what you imply with that, the consensus from that thread was to not
change to KiB/KB etc?
cheers ./daniel
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: kilobyte unit spelled "K bytes"
@ 2019-09-03 04:07 Michael Paquier <michael@paquier.xyz>
parent: Daniel Gustafsson <daniel@yesql.se>
0 siblings, 0 replies; 5+ messages in thread
From: Michael Paquier @ 2019-09-03 04:07 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Nikolay Samokhvalov <samokhvalov@gmail.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Fri, Aug 30, 2019 at 10:37:26AM +0200, Daniel Gustafsson wrote:
> Not sure what you imply with that, the consensus from that thread was to not
> change to KiB/KB etc?
Yes, that's what I recall as well on the matter. I have just applied
your original patch on HEAD.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2019-09-03 04:07 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29 10:15 kilobyte unit spelled "K bytes" Daniel Gustafsson <daniel@yesql.se>
2019-08-30 00:14 ` Michael Paquier <michael@paquier.xyz>
2019-08-30 00:34 ` Nikolay Samokhvalov <samokhvalov@gmail.com>
2019-08-30 08:37 ` Daniel Gustafsson <daniel@yesql.se>
2019-09-03 04:07 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox