From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Jonathan S. Katz" <jkatz@postgresql.org>
cc: "David G. Johnston" <david.g.johnston@gmail.com>, splarv@ya.ru,
        pgsql-docs@lists.postgresql.org
Subject: Re: 'value' has special behaviour in alter system
In-reply-to: <f601ac59-16f9-0b75-2831-e212bae7fda5@postgresql.org>
References: <167105927893.1897.13227723035830709578@wrigleys.postgresql.org>
 <CAKFQuwbefvj25vYz-0KJ-62oCg8-BxAd3PButBZTJ-7PzUcGbQ@mail.gmail.com>
 <f601ac59-16f9-0b75-2831-e212bae7fda5@postgresql.org>
Comments: In-reply-to "Jonathan S. Katz" <jkatz@postgresql.org>
	message dated "Thu, 15 Dec 2022 11:50:33 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3417416.1671124227.1@sss.pgh.pa.us>
Date: Thu, 15 Dec 2022 12:10:27 -0500
Message-ID: <3417417.1671124227@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3417417.1671124227%40sss.pgh.pa.us>
Precedence: bulk

"Jonathan S. Katz" <jkatz@postgresql.org> writes:
> On 12/15/22 10:50 AM, David G. Johnston wrote:
>> I suggest changing it to:
>> SET configuration_parameter { TO | = } { value [, ...] | DEFAULT }

> +1 in general. I would also suggest we add an example in the Examples 
> section to show what the output is when you add single-quotes.

I think the core problem here is that the syntax diagram and discussion
don't clearly discuss the behavior for list values.  David's version of
the syntax diagram looks fine, but not sure about the text.  There likely
needs to be some explicit acknowledgement of the fact that some GUCs
act differently than others (cf GUC_LIST_INPUT and GUC_LIST_QUOTE flags).

+1 for examples, for sure.

			regards, tom lane