public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: [email protected]
Cc: Peter Eisentraut <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: PostgreSQL-documentation <[email protected]>
Subject: Re: [HACKERS] New XML section for documentation
Date: Fri, 15 Sep 2006 13:20:26 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

"Nikolay Samokhvalov" <[email protected]> writes:
> On 8/26/06, Peter Eisentraut <[email protected]> wrote:
>> "Valid" and "well-formed" have very specific distinct meanings in XML.
>> (Note that "check" doesn't have any meaning there.)  We will eventually
>> want a method to verify both the validity and the well-formedness.
>> 
>> I think that a function called xml_valid checks for well-formedness is
>> an outright bug and needs to be fixed.

> That's exactly what I'm talking about. xml_valid() is wrong name and
> it may confuse people.

> Bruce suggested to use overload to keep backward compat. - in other
> words, 1-arg function for checking for well-formedness and 2-arg
> function for validation process. That's bad too:

ISTM the right answer is to add xml_is_well_formed() in this release
and have xml_valid as an alias for it, with documentation explaining
that xml_valid is deprecated and will be removed in the next release.
Then we can add a proper validity-checking function too.

Nikolay submitted a patch later
http://archives.postgresql.org/pgsql-patches/2006-09/msg00123.php
that does part of this and can easily be adapted to add the alias.

His patch also adds an xpath_array() function --- what do people
think about that?  It's well past feature freeze ... now we've always
been laxer about contrib than the core code, but still I'm inclined
to say that that function should wait for 8.3.

Comments?  It's time to get a move on with resolving this.

			regards, tom lane

view thread (30+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [HACKERS] New XML section for documentation
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox