pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedObsolete description in pg_ctl-ref.sgml
9+ messages / 3 participants
[nested] [flat]
* Obsolete description in pg_ctl-ref.sgml
@ 2010-12-09 11:45 Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 9+ messages in thread
From: Fujii Masao @ 2010-12-09 11:45 UTC (permalink / raw)
To: pgsql-docs
Hi,
I found some obsolete descriptions in pg_ctl-ref.sgml.
Could you apply the attached patch?
> Notes
>
> Waiting for complete startup is not a well-defined operation and
> might fail if access control is set up so that a local client cannot
> connect without manual interaction (e.g., password authentication).
> For additional connection variables, see Section 31.13, and for
> passwords, also see Section 31.14.
The above also seems to be obsolete, thanks to recently-introduced
PQping. Can we remove that?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachments:
update_pg_ctl_doc_v1.patch (application/octet-stream, 1.5K) download
*** a/doc/src/sgml/ref/pg_ctl-ref.sgml
--- b/doc/src/sgml/ref/pg_ctl-ref.sgml
***************
*** 582,588 **** PostgreSQL documentation
<para>
Restarting the server is almost equivalent to stopping the
server and starting it again
! except that <command>pg_ctl</command> saves and reuses the command line options that
were passed to the previously running instance. To restart
the server in the simplest form, use:
<screen>
--- 582,588 ----
<para>
Restarting the server is almost equivalent to stopping the
server and starting it again
! except that <command>pg_ctl</command> reuses the command line options that
were passed to the previously running instance. To restart
the server in the simplest form, use:
<screen>
***************
*** 615,623 **** PostgreSQL documentation
<screen>
<prompt>$</prompt> <userinput>pg_ctl status</userinput>
<computeroutput>
! pg_ctl: server is running (pid: 13718)
! Command line was:
! /usr/local/pgsql/bin/postgres '-D' '/usr/local/pgsql/data' '-p' '5433' '-B' '128'
</computeroutput>
</screen>
This is the command line that would be invoked in restart mode.
--- 615,622 ----
<screen>
<prompt>$</prompt> <userinput>pg_ctl status</userinput>
<computeroutput>
! pg_ctl: server is running (PID: 13718)
! /usr/local/pgsql/bin/postgres "-D" "/usr/local/pgsql/data" "-p" "5433" "-B" "128"
</computeroutput>
</screen>
This is the command line that would be invoked in restart mode.
* Re: Obsolete description in pg_ctl-ref.sgml
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
@ 2010-12-11 04:27 ` Robert Haas <robertmhaas@gmail.com>
2010-12-13 04:21 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 9+ messages in thread
From: Robert Haas @ 2010-12-11 04:27 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@gmail.com>; +Cc: pgsql-docs
On Thu, Dec 9, 2010 at 6:45 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> I found some obsolete descriptions in pg_ctl-ref.sgml.
> Could you apply the attached patch?
I'm just as happy to retain "saves and reuses" vs. just "reuses", but
the rest of this looks right, so committed.
>> Notes
>>
>> Waiting for complete startup is not a well-defined operation and
>> might fail if access control is set up so that a local client cannot
>> connect without manual interaction (e.g., password authentication).
>> For additional connection variables, see Section 31.13, and for
>> passwords, also see Section 31.14.
>
> The above also seems to be obsolete, thanks to recently-introduced
> PQping. Can we remove that?
Should we remove only the first sentence and keep the second one, or
is it more appropriate to remove the whole thing?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Obsolete description in pg_ctl-ref.sgml
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
@ 2010-12-13 04:21 ` Fujii Masao <masao.fujii@gmail.com>
2010-12-14 21:35 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 9+ messages in thread
From: Fujii Masao @ 2010-12-13 04:21 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-docs
On Sat, Dec 11, 2010 at 1:27 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>> Notes
>>>
>>> Waiting for complete startup is not a well-defined operation and
>>> might fail if access control is set up so that a local client cannot
>>> connect without manual interaction (e.g., password authentication).
>>> For additional connection variables, see Section 31.13, and for
>>> passwords, also see Section 31.14.
>>
>> The above also seems to be obsolete, thanks to recently-introduced
>> PQping. Can we remove that?
>
> Should we remove only the first sentence and keep the second one, or
> is it more appropriate to remove the whole thing?
At least the reference to section 31.14 is needless since password
authentication doesn't affect the pg_ctl -w for now. But, on the second
thought, it can still fail because of miss-configuration of connection
variable, for example PGHOST. So we might have to leave the first
sentence with minor change. How about?:
-----------------
Notes
Waiting for complete startup is not a well-defined operation and
might fail if access control is set up so that a local client cannot
connect because of wrong configuration (e.g., name of host to
connect to). For additional connection variables, see Section 31.13.
-----------------
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Obsolete description in pg_ctl-ref.sgml
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-13 04:21 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
@ 2010-12-14 21:35 ` Robert Haas <robertmhaas@gmail.com>
2010-12-15 00:17 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 9+ messages in thread
From: Robert Haas @ 2010-12-14 21:35 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@gmail.com>; +Cc: pgsql-docs
On Sun, Dec 12, 2010 at 11:21 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Sat, Dec 11, 2010 at 1:27 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>>> Notes
>>>>
>>>> Waiting for complete startup is not a well-defined operation and
>>>> might fail if access control is set up so that a local client cannot
>>>> connect without manual interaction (e.g., password authentication).
>>>> For additional connection variables, see Section 31.13, and for
>>>> passwords, also see Section 31.14.
>>>
>>> The above also seems to be obsolete, thanks to recently-introduced
>>> PQping. Can we remove that?
>>
>> Should we remove only the first sentence and keep the second one, or
>> is it more appropriate to remove the whole thing?
>
> At least the reference to section 31.14 is needless since password
> authentication doesn't affect the pg_ctl -w for now. But, on the second
> thought, it can still fail because of miss-configuration of connection
> variable, for example PGHOST.
I thought PQping() was supposed to handle that correctly. There are
four return values: PQPING_OK, PQPING_REJECT, PQPING_NO_RESPONSE,
PQPING_NO_ATTEMPT. I believe the last is intended to cover blatant
misconfiguration. Or maybe I'm not understanding what you're
referring to.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Obsolete description in pg_ctl-ref.sgml
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-13 04:21 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-14 21:35 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
@ 2010-12-15 00:17 ` Fujii Masao <masao.fujii@gmail.com>
2010-12-16 02:10 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 9+ messages in thread
From: Fujii Masao @ 2010-12-15 00:17 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-docs
On Wed, Dec 15, 2010 at 6:35 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> At least the reference to section 31.14 is needless since password
>> authentication doesn't affect the pg_ctl -w for now. But, on the second
>> thought, it can still fail because of miss-configuration of connection
>> variable, for example PGHOST.
>
> I thought PQping() was supposed to handle that correctly. There are
> four return values: PQPING_OK, PQPING_REJECT, PQPING_NO_RESPONSE,
> PQPING_NO_ATTEMPT. I believe the last is intended to cover blatant
> misconfiguration.
True. But even though the server is running normally, the misconfiguration
might still make PQping return PQPING_NO_ATTEMPT and make pg_ctl -w
fail to wait for complete startup. Currently misconfiguration of password
authentication doesn't interfere with pg_ctl -w, so we can remove the
reference to that. But other misconfigurations can be still harm, so I thought
the sentence still needs to be in the document.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Obsolete description in pg_ctl-ref.sgml
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-13 04:21 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-14 21:35 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-15 00:17 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
@ 2010-12-16 02:10 ` Robert Haas <robertmhaas@gmail.com>
2010-12-16 03:41 ` Re: Obsolete description in pg_ctl-ref.sgml Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 9+ messages in thread
From: Robert Haas @ 2010-12-16 02:10 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@gmail.com>; +Cc: pgsql-docs
On Tue, Dec 14, 2010 at 7:17 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Wed, Dec 15, 2010 at 6:35 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>>> At least the reference to section 31.14 is needless since password
>>> authentication doesn't affect the pg_ctl -w for now. But, on the second
>>> thought, it can still fail because of miss-configuration of connection
>>> variable, for example PGHOST.
>>
>> I thought PQping() was supposed to handle that correctly. There are
>> four return values: PQPING_OK, PQPING_REJECT, PQPING_NO_RESPONSE,
>> PQPING_NO_ATTEMPT. I believe the last is intended to cover blatant
>> misconfiguration.
>
> True. But even though the server is running normally, the misconfiguration
> might still make PQping return PQPING_NO_ATTEMPT and make pg_ctl -w
> fail to wait for complete startup. Currently misconfiguration of password
> authentication doesn't interfere with pg_ctl -w, so we can remove the
> reference to that. But other misconfigurations can be still harm, so I thought
> the sentence still needs to be in the document.
Hmm. I'm inclined to just remove that sentence. The fact that you
can make the operation fail by pointing it at someplace where there's
not a server listening doesn't really seem to merit a disclaimer. I
think waiting IS a well-defined operation now; it just won't succeed
if you configure it in a way that doesn't make sense.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Obsolete description in pg_ctl-ref.sgml
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-13 04:21 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-14 21:35 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-15 00:17 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-16 02:10 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
@ 2010-12-16 03:41 ` Tom Lane <tgl@sss.pgh.pa.us>
2010-12-17 01:57 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 9+ messages in thread
From: Tom Lane @ 2010-12-16 03:41 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: Fujii Masao <masao.fujii@gmail.com>; pgsql-docs
Robert Haas <robertmhaas@gmail.com> writes:
> Hmm. I'm inclined to just remove that sentence. The fact that you
> can make the operation fail by pointing it at someplace where there's
> not a server listening doesn't really seem to merit a disclaimer. I
> think waiting IS a well-defined operation now; it just won't succeed
> if you configure it in a way that doesn't make sense.
+1
regards, tom lane
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Obsolete description in pg_ctl-ref.sgml
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-13 04:21 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-14 21:35 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-15 00:17 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-16 02:10 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-16 03:41 ` Re: Obsolete description in pg_ctl-ref.sgml Tom Lane <tgl@sss.pgh.pa.us>
@ 2010-12-17 01:57 ` Robert Haas <robertmhaas@gmail.com>
2010-12-17 02:00 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 9+ messages in thread
From: Robert Haas @ 2010-12-17 01:57 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Fujii Masao <masao.fujii@gmail.com>; pgsql-docs
On Wed, Dec 15, 2010 at 10:41 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> Hmm. I'm inclined to just remove that sentence. The fact that you
>> can make the operation fail by pointing it at someplace where there's
>> not a server listening doesn't really seem to merit a disclaimer. I
>> think waiting IS a well-defined operation now; it just won't succeed
>> if you configure it in a way that doesn't make sense.
>
> +1
On further review, removing only the first sentence doesn't seem very
sensible - one of the two links is also present just a few lines up,
and mentioning just the other one with no context seems pointless. So
I'm just going to remove the whole paragraph.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Obsolete description in pg_ctl-ref.sgml
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-13 04:21 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-14 21:35 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-15 00:17 ` Re: Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-16 02:10 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
2010-12-16 03:41 ` Re: Obsolete description in pg_ctl-ref.sgml Tom Lane <tgl@sss.pgh.pa.us>
2010-12-17 01:57 ` Re: Obsolete description in pg_ctl-ref.sgml Robert Haas <robertmhaas@gmail.com>
@ 2010-12-17 02:00 ` Fujii Masao <masao.fujii@gmail.com>
0 siblings, 0 replies; 9+ messages in thread
From: Fujii Masao @ 2010-12-17 02:00 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-docs
On Fri, Dec 17, 2010 at 10:57 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On further review, removing only the first sentence doesn't seem very
> sensible - one of the two links is also present just a few lines up,
> and mentioning just the other one with no context seems pointless. So
> I'm just going to remove the whole paragraph.
Fair enough.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2010-12-17 02:00 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-12-09 11:45 Obsolete description in pg_ctl-ref.sgml Fujii Masao <masao.fujii@gmail.com>
2010-12-11 04:27 ` Robert Haas <robertmhaas@gmail.com>
2010-12-13 04:21 ` Fujii Masao <masao.fujii@gmail.com>
2010-12-14 21:35 ` Robert Haas <robertmhaas@gmail.com>
2010-12-15 00:17 ` Fujii Masao <masao.fujii@gmail.com>
2010-12-16 02:10 ` Robert Haas <robertmhaas@gmail.com>
2010-12-16 03:41 ` Tom Lane <tgl@sss.pgh.pa.us>
2010-12-17 01:57 ` Robert Haas <robertmhaas@gmail.com>
2010-12-17 02:00 ` Fujii Masao <masao.fujii@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox