Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN1FD-0006Qe-CJ for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 22:35:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lN1FB-0000V2-2c for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 22:35:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN1FA-0000UB-Qz for pgsql-hackers@lists.postgresql.org; Thu, 18 Mar 2021 22:35:52 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN1F4-0003hj-Nj for pgsql-hackers@lists.postgresql.org; Thu, 18 Mar 2021 22:35:51 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 12IMZgow3818385; Thu, 18 Mar 2021 18:35:42 -0400 From: Tom Lane To: Thomas Munro cc: Tomas Vondra , Vik Fearing , Georgios Kokolatos , PostgreSQL Hackers , Erik Rijkers Subject: Re: GROUP BY DISTINCT In-reply-to: References: <161469758801.29967.4455067072614569957.pgcf@coridan.postgresql.org> <4294e82f-a134-5dbb-d9d6-03d72dce2e1e@postgresfriends.org> <3817d5ec-f3e4-e4b9-d169-271ae5d3cbe4@postgresfriends.org> <8c44df08-bb64-3d78-da1a-d24b7c9db39d@enterprisedb.com> <7137947a-87be-d04a-bf91-f42e47520daa@enterprisedb.com> <35077b31-2d62-1e31-0e2e-ddb52d590b73@enterprisedb.com> Comments: In-reply-to Thomas Munro message dated "Fri, 19 Mar 2021 10:57:13 +1300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3818383.1616106942.1@sss.pgh.pa.us> Date: Thu, 18 Mar 2021 18:35:42 -0400 Message-ID: <3818384.1616106942@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Thomas Munro writes: > On Fri, Mar 19, 2021 at 10:14 AM Tomas Vondra > wrote: >> Thanks for the info. So it's likely related to older gcc releases. The >> question is how to tweak the code to get rid of this ... > It's frustrating to have to do press-ups to fix a problem because a > zombie Debian 7 system is running with -Werror (though it's always > possible that it's telling us something interesting...). Anyway, I > think someone with a GCC < 4.8 compiler would have to investigate. I > was hoping to help, but none of my systems have one in easy-to-install > format... Hmm ... prairiedog isn't showing the warning, but maybe gaur will. I can take a look if nobody else is stepping up. regards, tom lane