From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
cc: Thomas Munro <thomas.munro@gmail.com>,
        Vik Fearing <vik@postgresfriends.org>,
        Georgios Kokolatos <gkokolatos@protonmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Erik Rijkers <er@xs4all.nl>
Subject: Re: GROUP BY DISTINCT
In-reply-to: <3828009.1616109022@sss.pgh.pa.us>
References: <bf3805a8-d7d1-ae61-fece-761b7ff41ecc@postgresfriends.org>
 <c350ff6b-d70d-9952-be23-a18855b62589@postgresfriends.org>
 <161469758801.29967.4455067072614569957.pgcf@coridan.postgresql.org>
 <4294e82f-a134-5dbb-d9d6-03d72dce2e1e@postgresfriends.org>
 <b95ee556-c527-04b8-6cae-f55950dde94b@enterprisedb.com>
 <3817d5ec-f3e4-e4b9-d169-271ae5d3cbe4@postgresfriends.org>
 <8c44df08-bb64-3d78-da1a-d24b7c9db39d@enterprisedb.com>
 <7137947a-87be-d04a-bf91-f42e47520daa@enterprisedb.com>
 <35077b31-2d62-1e31-0e2e-ddb52d590b73@enterprisedb.com>
 <CA+hUKG+rJkXWjj_WFPE8cDp+9Av2T3bQfEfEBd=W+PdWVCk8mg@mail.gmail.com>
 <aa87b9b9-6a14-a84a-574f-e3ad2ce2504c@enterprisedb.com>
 <CA+hUKG+6mHO82VCp9TYLcwf_x8qjd-jrxLnYCTpZOebmnrLzww@mail.gmail.com>
 <3818384.1616106942@sss.pgh.pa.us> <3828009.1616109022@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 18 Mar 2021 19:10:22 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3858395.1616110003.1@sss.pgh.pa.us>
Date: Thu, 18 Mar 2021 19:26:43 -0400
Message-ID: <3858396.1616110003@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3858396.1616110003%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> This is gcc 4.5, but hopefully whatever shuts it up will also work on 4.7.
> I'll work on figuring that out.

Actually, the problem is pretty obvious after comparing this use
of foreach_delete_current() to every other one.  I'm not sure why
the compiler warnings are phrased just as they are, but the fix
I just pushed does make 4.5 happy.

			regards, tom lane