Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1kHeJ7-0006og-Ob
	for pgsql-docs@arkaria.postgresql.org; Mon, 14 Sep 2020 02:33:29 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1kHeJ6-0000Ua-5b
	for pgsql-docs@arkaria.postgresql.org; Mon, 14 Sep 2020 02:33:28 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1kHeJ6-0000UL-0C
	for pgsql-docs@lists.postgresql.org; Mon, 14 Sep 2020 02:33:28 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1kHeJ3-0000HZ-Vr
	for pgsql-docs@postgresql.org; Mon, 14 Sep 2020 02:33:26 +0000
Received: from hnk.local (p12054-ipngn2901funabasi.chiba.ocn.ne.jp
 [153.212.171.54])
	by oss.nttdata.com (Postfix) with ESMTPSA id 42865602EF;
	Mon, 14 Sep 2020 11:33:24 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com
Subject: Re: Fix the example in the document of file-fdw
To: btkatsuragiyu <btkatsuragiyu@oss.nttdata.com>, pgsql-docs@postgresql.org
References: <0cd5a9ebbec58bb16fd3f6eb20e401d9@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <3b42a115-ebc9-d800-f51f-b5bf7a84201b@oss.nttdata.com>
Date: Mon, 14 Sep 2020 11:33:23 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <0cd5a9ebbec58bb16fd3f6eb20e401d9@oss.nttdata.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk



On 2020/09/14 11:19, btkatsuragiyu wrote:
> Although csvlog has the leader_pid field, the document of file-fdw
> that uses csvlog as an example does not reflect this fact.
> Concretely, the DDL for table definition does not have the leader_pid field.

This seems an oversight of commit b8fdee7d0c.

> This patch fixes the DDL in the document of file-fdw.

Thanks for the patch! LGTM. I will commit it.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION