public inbox for [email protected]  

help / color / mirror / Atom feed

From: Laurenz Albe <[email protected]>
To: Anton Voloshin <[email protected]>
To: [email protected]
Subject: Re: [PATCH] add link to domain data types section from locale documentation
Date: Thu, 27 May 2021 09:45:27 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On Thu, 2021-04-01 at 11:45 +0300, Anton Voloshin wrote:
> On 01.04.2021 11:29, Jürgen Purtz wrote:
> > It's likely that the term "domain" within an SQL context confuse some 
> > people. An additional remark in the glossary concerning the SQL and IP 
> > meaning may be helpful.
> 
> Nice touch, thanks!

I have had a look at the patch.

The addition to the glossary is good.

I spotted this in "src/sgml/glossary.sgml":

  <glossentry id="glossary-constraint">
   <glossterm>Constraint</glossterm>
   <glossdef>
    <para>
     A restriction on the values of data allowed within a
     <glossterm linkend="glossary-table">table</glossterm>,
     or in attributes of a
     <!-- XXX Should have term "domain". Need term "type" for that. -->
     <firstterm>domain</firstterm>.
    </para>
    <para>
     For more information, see
     <xref linkend="ddl-constraints"/>.
    </para>
   </glossdef>
  </glossentry>

You should add a link to the new "domain" entry from there.
I think the comment should be removed.

I like the new link from "src/sgml/charset.sgml", but I think that
there are a few other places in the documentation that are likely to be
read by people who don't know about SQL domains and could benefit from such
a link:

- src/sgml/earthdistance.sgml

- src/sgml/lo.sgml

- src/sgml/information_schema.sgml (the entries about "check_constraints",
  "column_domain_usage", "data_type_privileges", "domain_constraints",
  "domain_catalog", "domain_udt_usage", "domains" and the description below
  "columns")

This selection is a bit arbitrary, I admit.

Yours,
Laurenz Albe

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] add link to domain data types section from locale documentation
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox