Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 13F3164FC25 for ; Sat, 6 Dec 2008 00:29:23 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 66607-06 for ; Sat, 6 Dec 2008 00:29:14 -0400 (AST) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from fk-out-0910.google.com (fk-out-0910.google.com [209.85.128.189]) by mail.postgresql.org (Postfix) with ESMTP id 6CE8364FC1E for ; Sat, 6 Dec 2008 00:29:12 -0400 (AST) Received: by fk-out-0910.google.com with SMTP id e30so289609fke.3 for ; Fri, 05 Dec 2008 20:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=q+a+yUm8AY9L12lvPXxGyE/PwHztJgb2vmcC7md0M0M=; b=J5kha+RgCZdAKkk98zrtNu7tZ18G4kSMZcccEx4gqe6Kdg3qFmH6+KxdsiW0WGJ85y 7qR0XNSJ2XTLkcNqOMkP5AwMtQeY677q3qhxulLoorbKsmiosLQIgNrUe3bXbQwoAcdB 9shXENhtwL0/bKGQfRD5D0zZLLXp9XOol6yUw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=dRtieOa/kyC7N0yPj30QcFRNMDcaM6RYjpHJGceyHuY/42+u+u0xFWOPg+dRNC56kD snwoxe+ZRMPOhLj/OJs4YWNA21aq5X3R1Pb0CDXA/aYy12hzo64kjQANDn9Hn1Dwv7Em ueZn89TroMco2g/Kb1hGbETayUCDhg8gMvczo= Received: by 10.181.199.16 with SMTP id b16mr260740bkq.142.1228537751016; Fri, 05 Dec 2008 20:29:11 -0800 (PST) Received: by 10.180.206.11 with HTTP; Fri, 5 Dec 2008 20:29:10 -0800 (PST) Message-ID: <3f0b79eb0812052029r1ee3a7b8n4aec36fc36b09d7a@mail.gmail.com> Date: Sat, 6 Dec 2008 13:29:10 +0900 From: "Fujii Masao" To: "Randy Isbell" Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION Cc: pgsql-bugs@postgresql.org In-Reply-To: <200812051441.mB5EfG1M007309@wwwmaster.postgresql.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_52814_32427594.1228537750996" References: <200812051441.mB5EfG1M007309@wwwmaster.postgresql.org> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200812/28 X-Sequence-Number: 21844 ------=_Part_52814_32427594.1228537750996 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Fri, Dec 5, 2008 at 11:41 PM, Randy Isbell wrote: > > The following bug has been logged online: > > Bug reference: 4566 > Logged by: Randy Isbell > Email address: jisbell@cisco.com > PostgreSQL version: 8.3.4 > Operating system: FreeBSD 6.2 > Description: pg_stop_backup() reports incorrect STOP WAL LOCATION > Details: > > An inconsistency exists between the segment name reported by > pg_stop_backup() and the actual WAL file name. > > > SELECT pg_start_backup('filename'); > pg_start_backup > ----------------- > 10/FE1E2BAC > (1 row) > > Later: > SELECT pg_stop_backup(); > pg_stop_backup > ---------------- > 10/FF000000 > (1 row) > > The resulting *.backup file: > > START WAL LOCATION: 10/FE1E2BAC (file 0000000200000010000000FE) > STOP WAL LOCATION: 10/FF000000 (file 0000000200000010000000FF) > CHECKPOINT LOCATION: 10/FE1E2BAC > START TIME: 2008-11-09 01:15:06 CST > LABEL: /bck/db/sn200811090115.tar.gz > STOP TIME: 2008-11-09 01:15:48 CST > > In my 8.3.4 instance, WAL file naming occurs as: > > ... > 0000000100000003000000FD > 0000000100000003000000FE > 000000010000000400000000 > 000000010000000400000001 > ... > > WAL files never end in 'FF'. This causes a problem when trying to collect > the ending WAL file for backup. It's a bug of pg_stop_backup(), which has been talked before. http://archives.postgresql.org/pgsql-hackers/2008-12/msg00108.php Attached is a patch against HEAD. I think that we should also backport. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center ------=_Part_52814_32427594.1228537750996 Content-Type: text/x-patch; name=stopxlogfilename_bugfix.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fodrhxye0 Content-Disposition: attachment; filename=stopxlogfilename_bugfix.patch PyBHTlVtYWtlZmlsZQo/IGNvbmZpZy5sb2cKPyBjb25maWcuc3RhdHVzCj8gc3JjL01ha2VmaWxl Lmdsb2JhbAo/IHNyYy9iYWNrZW5kL3Bvc3RncmVzCj8gc3JjL2JhY2tlbmQvY2F0YWxvZy9wb3N0 Z3Jlcy5ia2kKPyBzcmMvYmFja2VuZC9jYXRhbG9nL3Bvc3RncmVzLmRlc2NyaXB0aW9uCj8gc3Jj L2JhY2tlbmQvY2F0YWxvZy9wb3N0Z3Jlcy5zaGRlc2NyaXB0aW9uCj8gc3JjL2JhY2tlbmQvc25v d2JhbGwvc25vd2JhbGxfY3JlYXRlLnNxbAo/IHNyYy9iYWNrZW5kL3V0aWxzL3Byb2Jlcy5oCj8g c3JjL2JhY2tlbmQvdXRpbHMvbWIvY29udmVyc2lvbl9wcm9jcy9jb252ZXJzaW9uX2NyZWF0ZS5z cWwKPyBzcmMvYmluL2luaXRkYi9pbml0ZGIKPyBzcmMvYmluL3BnX2NvbmZpZy9wZ19jb25maWcK PyBzcmMvYmluL3BnX2NvbnRyb2xkYXRhL3BnX2NvbnRyb2xkYXRhCj8gc3JjL2Jpbi9wZ19jdGwv cGdfY3RsCj8gc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXAKPyBzcmMvYmluL3BnX2R1bXAvcGdfZHVt cGFsbAo/IHNyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3JlCj8gc3JjL2Jpbi9wZ19yZXNldHhsb2cv cGdfcmVzZXR4bG9nCj8gc3JjL2Jpbi9wc3FsL3BzcWwKPyBzcmMvYmluL3NjcmlwdHMvY2x1c3Rl cmRiCj8gc3JjL2Jpbi9zY3JpcHRzL2NyZWF0ZWRiCj8gc3JjL2Jpbi9zY3JpcHRzL2NyZWF0ZWxh bmcKPyBzcmMvYmluL3NjcmlwdHMvY3JlYXRldXNlcgo/IHNyYy9iaW4vc2NyaXB0cy9kcm9wZGIK PyBzcmMvYmluL3NjcmlwdHMvZHJvcGxhbmcKPyBzcmMvYmluL3NjcmlwdHMvZHJvcHVzZXIKPyBz cmMvYmluL3NjcmlwdHMvcmVpbmRleGRiCj8gc3JjL2Jpbi9zY3JpcHRzL3ZhY3V1bWRiCj8gc3Jj L2luY2x1ZGUvcGdfY29uZmlnLmgKPyBzcmMvaW5jbHVkZS9zdGFtcC1oCj8gc3JjL2ludGVyZmFj ZXMvZWNwZy9jb21wYXRsaWIvZXhwb3J0cy5saXN0Cj8gc3JjL2ludGVyZmFjZXMvZWNwZy9jb21w YXRsaWIvbGliZWNwZ19jb21wYXQuc28uMy4xCj8gc3JjL2ludGVyZmFjZXMvZWNwZy9lY3BnbGli L2V4cG9ydHMubGlzdAo/IHNyYy9pbnRlcmZhY2VzL2VjcGcvZWNwZ2xpYi9saWJlY3BnLnNvLjYu MQo/IHNyYy9pbnRlcmZhY2VzL2VjcGcvaW5jbHVkZS9lY3BnX2NvbmZpZy5oCj8gc3JjL2ludGVy ZmFjZXMvZWNwZy9wZ3R5cGVzbGliL2V4cG9ydHMubGlzdAo/IHNyYy9pbnRlcmZhY2VzL2VjcGcv cGd0eXBlc2xpYi9saWJwZ3R5cGVzLnNvLjMuMQo/IHNyYy9pbnRlcmZhY2VzL2VjcGcvcHJlcHJv Yy9lY3BnCj8gc3JjL2ludGVyZmFjZXMvbGlicHEvZXhwb3J0cy5saXN0Cj8gc3JjL2ludGVyZmFj ZXMvbGlicHEvbGlicHEuc28uNS4yCj8gc3JjL3BvcnQvcGdfY29uZmlnX3BhdGhzLmgKPyBzcmMv dGVzdC9yZWdyZXNzL2xvZwo/IHNyYy90ZXN0L3JlZ3Jlc3MvcGdfcmVncmVzcwo/IHNyYy90ZXN0 L3JlZ3Jlc3MvcmVzdWx0cwo/IHNyYy90ZXN0L3JlZ3Jlc3MvdGVzdHRhYmxlc3BhY2UKPyBzcmMv dGVzdC9yZWdyZXNzL3RtcF9jaGVjawo/IHNyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvY29uc3Ry YWludHMub3V0Cj8gc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jb3B5Lm91dAo/IHNyYy90ZXN0 L3JlZ3Jlc3MvZXhwZWN0ZWQvY3JlYXRlX2Z1bmN0aW9uXzEub3V0Cj8gc3JjL3Rlc3QvcmVncmVz cy9leHBlY3RlZC9jcmVhdGVfZnVuY3Rpb25fMi5vdXQKPyBzcmMvdGVzdC9yZWdyZXNzL2V4cGVj dGVkL2xhcmdlb2JqZWN0Lm91dAo/IHNyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvbGFyZ2VvYmpl Y3RfMS5vdXQKPyBzcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL21pc2Mub3V0Cj8gc3JjL3Rlc3Qv cmVncmVzcy9leHBlY3RlZC90YWJsZXNwYWNlLm91dAo/IHNyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2Nv bnN0cmFpbnRzLnNxbAo/IHNyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2NvcHkuc3FsCj8gc3JjL3Rlc3Qv cmVncmVzcy9zcWwvY3JlYXRlX2Z1bmN0aW9uXzEuc3FsCj8gc3JjL3Rlc3QvcmVncmVzcy9zcWwv Y3JlYXRlX2Z1bmN0aW9uXzIuc3FsCj8gc3JjL3Rlc3QvcmVncmVzcy9zcWwvbGFyZ2VvYmplY3Qu c3FsCj8gc3JjL3Rlc3QvcmVncmVzcy9zcWwvbWlzYy5zcWwKPyBzcmMvdGVzdC9yZWdyZXNzL3Nx bC90YWJsZXNwYWNlLnNxbAo/IHNyYy90aW1lem9uZS96aWMKSW5kZXg6IHNyYy9iYWNrZW5kL2Fj Y2Vzcy90cmFuc2FtL3hsb2cuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvcHJvamVjdHMvY3Zzcm9v dC9wZ3NxbC9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuMzIzCmRpZmYgLWMgLXIxLjMyMyB4bG9nLmMKKioqIHNyYy9iYWNrZW5kL2FjY2Vz cy90cmFuc2FtL3hsb2cuYwkzIERlYyAyMDA4IDA4OjIwOjExIC0wMDAwCTEuMzIzCi0tLSBzcmMv YmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMJNiBEZWMgMjAwOCAwNDoyMTowNSAtMDAwMAoq KioqKioqKioqKioqKioKKioqIDY3MTAsNjcxNiAqKioqCiAgCSAqLwogIAlzdG9wcG9pbnQgPSBS ZXF1ZXN0WExvZ1N3aXRjaCgpOwogIAohIAlYTEJ5dGVUb1NlZyhzdG9wcG9pbnQsIF9sb2dJZCwg X2xvZ1NlZyk7CiAgCVhMb2dGaWxlTmFtZShzdG9weGxvZ2ZpbGVuYW1lLCBUaGlzVGltZUxpbmVJ RCwgX2xvZ0lkLCBfbG9nU2VnKTsKICAKICAJLyogVXNlIHRoZSBsb2cgdGltZXpvbmUgaGVyZSwg bm90IHRoZSBzZXNzaW9uIHRpbWV6b25lICovCi0tLSA2NzEwLDY3MTYgLS0tLQogIAkgKi8KICAJ c3RvcHBvaW50ID0gUmVxdWVzdFhMb2dTd2l0Y2goKTsKICAKISAJWExCeXRlVG9QcmV2U2VnKHN0 b3Bwb2ludCwgX2xvZ0lkLCBfbG9nU2VnKTsKICAJWExvZ0ZpbGVOYW1lKHN0b3B4bG9nZmlsZW5h bWUsIFRoaXNUaW1lTGluZUlELCBfbG9nSWQsIF9sb2dTZWcpOwogIAogIAkvKiBVc2UgdGhlIGxv ZyB0aW1lem9uZSBoZXJlLCBub3QgdGhlIHNlc3Npb24gdGltZXpvbmUgKi8K ------=_Part_52814_32427594.1228537750996--