Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 99DFC63230F for ; Thu, 15 Jan 2009 10:16:00 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 05228-01 for ; Thu, 15 Jan 2009 10:15:57 -0400 (AST) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.232]) by mail.postgresql.org (Postfix) with ESMTP id 5FE156322BC for ; Thu, 15 Jan 2009 10:15:57 -0400 (AST) Received: by rv-out-0506.google.com with SMTP id b25so1133178rvf.43 for ; Thu, 15 Jan 2009 06:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=qDNBy/AAJGnPNIvt1KhzRgnrVm0bNfAcnpT8JGWq4ho=; b=SVnEZHOk1d5iNAMU/IyTtZVgQl3FQQZnNid21zfaXPzEBikjEYRLFNtQ7Sph6sS9tT cBnb2HjYcnmhQJq7U7pYkTF5sZVOucxEGwkLSmYoZX6TvSXj3rFwPZGmqa25T514xAFi +vdcU+EW+iHcvqqnChH4rIvxa7UbWQl5PEwNU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=erx1nXUG7mmXg33KuVBK9Fg0nZu2hqNU5JSbuAkjw0Ucza+wE8P0v9j0S8Rf2vwsV9 woYvgyrrPu30s2ETCUniITDIh2CjOB4QQKuOk10+XMhmlZoJdwvIr+q+wo9ltE7B2Hf7 J1zjqJzmHAlUDVPte1gem57qdh2Z7HKJLF4sA= Received: by 10.141.162.5 with SMTP id p5mr631578rvo.193.1232028955251; Thu, 15 Jan 2009 06:15:55 -0800 (PST) Received: by 10.141.133.4 with HTTP; Thu, 15 Jan 2009 06:15:55 -0800 (PST) Message-ID: <3f0b79eb0901150615g133f845erc39faf19793d5977@mail.gmail.com> Date: Thu, 15 Jan 2009 23:15:55 +0900 From: "Fujii Masao" To: "Heikki Linnakangas" Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION Cc: "Bruce Momjian" , "Randy Isbell" , pgsql-bugs@postgresql.org In-Reply-To: <496F2795.70105@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200901150150.n0F1oV113850@momjian.us> <496F2795.70105@enterprisedb.com> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200901/93 X-Sequence-Number: 22075 Hi, On Thu, Jan 15, 2009 at 9:09 PM, Heikki Linnakangas wrote: > I think not > (http://archives.postgresql.org/pgsql-hackers/2008-12/msg00126.php). The > return value of pg_stop_backup() is currently the same as > pg_switch_xlog()'s: the location of the last byte before the XLOG switch + > 1. The proposed patch would remove the "+ 1". Seems like an unnecessary API > change, and I don't recall any reason why the new definition would be > better. My patch doesn't change the return value of pg_stop_backup(), it's still the same as the return value of pg_switch_xlog(). Only a part of backup history file (the file name including stop wal location) is changed. Currently, the file name is wrong if stop wal location indicates a boundary byte. This would confuse the user, I think. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center