Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 1F2E4632A4C for ; Thu, 4 Feb 2010 20:54:32 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 63469-09 for ; Fri, 5 Feb 2010 00:54:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-gx0-f218.google.com (mail-gx0-f218.google.com [209.85.217.218]) by mail.postgresql.org (Postfix) with ESMTP id 988D1632651 for ; Thu, 4 Feb 2010 20:54:21 -0400 (AST) Received: by gxk10 with SMTP id 10so898131gxk.3 for ; Thu, 04 Feb 2010 16:54:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=6HissTTGgIctJ89NQAcGKdhxy05U4/viupGF5nETSOA=; b=LZKynwn18+WLffsKJZ5MD5QIYFMgck611S5Nr6YupO4JeVieVXDbsh7MZRz2NwqyYF ciVahxNHa+GFKtMNxyqodN5Ne61n4KcsqNSBdkhBmmkUfrM74WupF/KGVJDouuIYPRry npPFdWgIvrUOGuqWRT8xiZIl0uvS7DUsbxyPc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=lB0hVp7z27BHNrcdCJOQ7GvB/dGfEzlu2fgVN0ZJOAS0RajO+LQyyzDyCNlA/1jtvx UHurZ9bmL4+1BelvynwXBZ8b/CEagtfiBe8tQwXm49wTtGC7HPFqJ0SmifOCI+99X9oz cfz+ceJwtOdA77W2xr9xKEOPishHjcSpLej3M= MIME-Version: 1.0 Received: by 10.101.3.4 with SMTP id f4mr2834869ani.10.1265331255543; Thu, 04 Feb 2010 16:54:15 -0800 (PST) In-Reply-To: <20100205090834.9BE7.52131E4D@oss.ntt.co.jp> References: <200812051441.mB5EfG1M007309@wwwmaster.postgresql.org> <3f0b79eb1002032328s46af0dcer64692245d3d94210@mail.gmail.com> <20100205090834.9BE7.52131E4D@oss.ntt.co.jp> Date: Fri, 5 Feb 2010 09:54:14 +0900 Message-ID: <3f0b79eb1002041654j348e1849h43c2d2eebe977606@mail.gmail.com> Subject: Re: Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION From: Fujii Masao To: Takahiro Itagaki Cc: PostgreSQL-development Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201002/336 X-Sequence-Number: 156679 On Fri, Feb 5, 2010 at 9:08 AM, Takahiro Itagaki wrote: >> But it was rejected because its change might break the existing app. > > It might break existing applications if it returns "FE" instead of "FF", > but never-used filename surprises users. (IMO, the existing apps probably > crash if "FF" returned, i.e, 1/256 of the time.) > > Should it return the *next* reasonable log filename instead of "FF"? > For example, 000000020000002000000000 for the above case. I wonder if that change also breaks the existing app. But since I've never seen the app that doesn't use that filename at face value, I agree to change the existing (odd for me) behavior of pg_stop_backup(). Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center