DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type;
	b=W3Z5oRq2Oq7htHUtyJVXFPpJ1aixRBX507LBkynxHh5g9LZbbnXOOU3wbIBp4d8Qhp
	qknJ91TEUj2HnZmr4tWlDoQIXduyTE6BlyabW++U33RG3BU/9dvejN67MLub8LBlPLVS
	spaWYrWJrxO+64i0v7TC/sLS7Pim7fjB2zjaw=
MIME-Version: 1.0
In-Reply-To: <3f0b79eb1002032328s46af0dcer64692245d3d94210@mail.gmail.com>
References: <200812051441.mB5EfG1M007309@wwwmaster.postgresql.org>
	<3f0b79eb1002032328s46af0dcer64692245d3d94210@mail.gmail.com>
Date: Mon, 15 Feb 2010 18:40:36 +0900
Message-ID: <3f0b79eb1002150140x1ffd58caieabb9fb0b0a13af1@mail.gmail.com>
Subject: Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL
	LOCATION
From: Fujii Masao <masao.fujii@gmail.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>,
	pgsql-docs@postgresql.org
Content-Type: multipart/mixed; boundary=000e0cd6ad3ecd3b55047fa068cf

--000e0cd6ad3ecd3b55047fa068cf
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Feb 4, 2010 at 4:28 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> Sorry for resurrecting an old argument.
> http://archives.postgresql.org/message-id/200812051441.mB5EfG1M007309@wwwmaster.postgresql.org
>
> I got the complaint about this behavior of the current pg_stop_backup()
> in this morning. I thought that this is the bug, and created the patch.
> But it was rejected because its change might break the existing app.
> Though I'm not sure if there is really such an app. Anyway I think that
> something like the following statements should be added into the document.
> Thought?
>
> ------------
> Note that the WAL file name in the backup history file cannot be used
> to determine which WAL files are required for the backup. Because it
> indicates the subsequent WAL file of the starting or ending one for
> the backup, when its location is exactly at a WAL file boundary (What
> is worse, sometimes it indicates a nonexistent WAL file).
> ------------

Here is the patch that adds the above-mentioned note. I think this
should be back-patched up to 8.0. Thought?

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--000e0cd6ad3ecd3b55047fa068cf
Content-Type: text/x-patch; charset=US-ASCII;
	name="note_backup_history_file_0215.patch"
Content-Disposition: attachment;
	filename="note_backup_history_file_0215.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g5p2lu5q0

KioqIGEvZG9jL3NyYy9zZ21sL2JhY2t1cC5zZ21sCi0tLSBiL2RvYy9zcmMvc2dtbC9iYWNrdXAu
c2dtbAoqKioqKioqKioqKioqKioKKioqIDg1OSw4NjQgKioqKiBTRUxFQ1QgcGdfc3RvcF9iYWNr
dXAoKTsKLS0tIDg1OSw4NjkgLS0tLQogICAgICBJZiB5b3UgdXNlZCB0aGUgbGFiZWwgdG8gaWRl
bnRpZnkgdGhlIGFzc29jaWF0ZWQgZHVtcCBmaWxlLAogICAgICB0aGVuIHRoZSBhcmNoaXZlZCBo
aXN0b3J5IGZpbGUgaXMgZW5vdWdoIHRvIHRlbGwgeW91IHdoaWNoIGR1bXAgZmlsZSB0bwogICAg
ICByZXN0b3JlLgorICAgICBOb3RlIHRoYXQgdGhlIFdBTCBmaWxlIG5hbWUgaW4gdGhlIGJhY2t1
cCBoaXN0b3J5IGZpbGUgY2Fubm90IGJlIHVzZWQKKyAgICAgdG8gZGV0ZXJtaW5lIHdoaWNoIFdB
TCBmaWxlcyBhcmUgcmVxdWlyZWQgZm9yIHRoZSBiYWNrdXAuIEJlY2F1c2UgaXQKKyAgICAgaW5k
aWNhdGVzIHRoZSBzdWJzZXF1ZW50IFdBTCBmaWxlIG9mIHRoZSBzdGFydGluZyBvciBlbmRpbmcg
b25lIGZvcgorICAgICB0aGUgYmFja3VwLCB3aGVuIGl0cyBsb2NhdGlvbiBpcyBleGFjdGx5IGF0
IGEgV0FMIGZpbGUgYm91bmRhcnkgKFdoYXQKKyAgICAgaXMgd29yc2UsIHNvbWV0aW1lcyBpdCBp
bmRpY2F0ZXMgYSBub25leGlzdGVudCBXQUwgZmlsZSkuCiAgICAgPC9wYXJhPgogIAogICAgIDxw
YXJhPgo=
--000e0cd6ad3ecd3b55047fa068cf--