public inbox for [email protected]  
help / color / mirror / Atom feed
From: Fujii Masao <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Thom Brown <[email protected]>
Cc: [email protected]
Subject: Re: Confusing link in streaming replication section
Date: Thu, 25 Feb 2010 18:34:12 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Thu, Feb 25, 2010 at 6:15 PM, Heikki Linnakangas
<[email protected]> wrote:
> Yeah, it's not very clear as it is.
>
> How about this:
>
> --- a/doc/src/sgml/recovery-config.sgml
> +++ b/doc/src/sgml/recovery-config.sgml
> @@ -193,7 +193,8 @@ restore_command = 'copy "C:\\server\\archivedir\\%f"
> "%p"'
>         <listitem>
>          <para>
>           Specifies a connection string to be used for the standby server
> -          to connect with the primary. This string is in the same format as
> +          to connect with the primary. This string is in the format
> +          accepted by the libpq <function>PQconnectdb</function> function,
>           described in <xref linkend="libpq-connect">. If any option is
>           unspecified in this string, then the corresponding environment
>           variable (see <xref linkend="libpq-envars">) is checked. If the

The following description in the document about PQconnectdb() doesn't fit
primary_conninfo because of restriction of readRecoveryCommandFile().

---------------
To write an empty value, or a value containing spaces,
surround it with single quotes, e.g., keyword = 'a value'. Single quotes
and backslashes within the value must be escaped with a backslash,
i.e., \' and \\.
---------------

So I'd like to copy and paste the description about conninfo except the
above. Thought? Here is the patch.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


Attachments:

  [text/x-patch] primary_conninfo_doc.patch (1.7K, 2-primary_conninfo_doc.patch)
  download | inline diff:
*** a/doc/src/sgml/recovery-config.sgml
--- b/doc/src/sgml/recovery-config.sgml
***************
*** 216,227 **** restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"'  # Windows
          <listitem>
           <para>
            Specifies a connection string to be used for the standby server
!           to connect with the primary. This string is in the same format as
!           described in <xref linkend="libpq-connect">. If any option is
!           unspecified in this string, then the corresponding environment
!           variable (see <xref linkend="libpq-envars">) is checked. If the
!           environment variable is not set either, then
!           defaults are used.
           </para>
           <para>
            The built-in replication requires that a host name (or host address)
--- 216,229 ----
          <listitem>
           <para>
            Specifies a connection string to be used for the standby server
!           to connect with the primary. This string can contain one or more
!           parameter settings separated by whitespace. Each parameter setting
!           is in the form <literal>keyword = value</literal>. Spaces around
!           the equal sign are optional. The currently recognized parameter
!           key words are the same as described in <xref linkend="libpq-connect">.
!           If any option is unspecified in this string, then the corresponding
!           environment variable (see <xref linkend="libpq-envars">) is checked.
!           If the environment variable is not set either, then defaults are used.
           </para>
           <para>
            The built-in replication requires that a host name (or host address)


view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Confusing link in streaming replication section
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox