Received: from maia.hub.org (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id AB6206324A6 for ; Fri, 26 Mar 2010 02:24:49 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 49218-04 for ; Fri, 26 Mar 2010 05:24:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-gx0-f214.google.com (mail-gx0-f214.google.com [209.85.217.214]) by mail.postgresql.org (Postfix) with ESMTP id EA615633755 for ; Fri, 26 Mar 2010 02:24:38 -0300 (ADT) Received: by gxk6 with SMTP id 6so5802247gxk.14 for ; Thu, 25 Mar 2010 22:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=rJNCZj77UuwWnmvghhbAw19zt/C9/bx0w9doiuZnlZc=; b=Bmk/DDSI3AJIUt2qaGDklBoMCJ9z12ULm3KR13J4jmPxq/OpVrQzAScdDhV5tuEMHF tAlEpWQYR+BmqmnncadcBkFUgbgxNE/orLm4VXY/J5Hi0sFXbKXe1gwAB84kLvqx3gpm BLyFzkRFd0HRE76z79CyfNla31w/nilSnj1NI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=HsRxe6f3Kqd74vpT++eTXQxtmOI7iVXqhiSUUpXvwBMAScVGQDFyO9ZEQnah32NX+Y +rQ/4L15ynj0QMPrqhnNhc6U/k+N9tJT7e0wJb40rL9Qy7kV8yzGchf3TXk36Twjdt3F +PyJrxvrhC7KCRlnBKcK8jp5DELS0tUSg8IcI= MIME-Version: 1.0 Received: by 10.100.253.9 with HTTP; Thu, 25 Mar 2010 22:24:35 -0700 (PDT) In-Reply-To: <4BAB5D4E.4000009@enterprisedb.com> References: <3f0b79eb1002092105r21e009d3v468496058ba04392@mail.gmail.com> <4BA0B079.3050301@enterprisedb.com> <3f0b79eb1003180727g7877743eq81274e014fe70a49@mail.gmail.com> <1268988724.3556.3.camel@ebony> <4BA361E4.7020309@enterprisedb.com> <3f0b79eb1003230017v16f4ecbeyc20e75beeffe8f1c@mail.gmail.com> <4BAA060A.2020000@enterprisedb.com> <3f0b79eb1003240620h209a0a40ud2063728b5db31a6@mail.gmail.com> <3f0b79eb1003240636y6ba3d739idc4555f88c98e32e@mail.gmail.com> <4BAB5D4E.4000009@enterprisedb.com> Date: Fri, 26 Mar 2010 14:24:35 +0900 Received: by 10.100.54.32 with SMTP id c32mr233693ana.191.1269581077915; Thu, 25 Mar 2010 22:24:37 -0700 (PDT) Message-ID: <3f0b79eb1003252224u9b91cc4la75547c6a2610ffc@mail.gmail.com> Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL From: Fujii Masao To: Heikki Linnakangas Cc: Simon Riggs , Aidan Van Dyk , PostgreSQL-development Content-Type: multipart/mixed; boundary=001485f5eaca29aad30482ad610f X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.061 tagged_above=-10 required=5 tests=AWL=0.538, BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201003/1026 X-Sequence-Number: 159802 --001485f5eaca29aad30482ad610f Content-Type: text/plain; charset=ISO-8859-1 On Thu, Mar 25, 2010 at 9:55 PM, Heikki Linnakangas wrote: > * Fix the bug of a spurious PANIC in archive recovery, if the WAL ends > in the middle of a WAL record that continues over a WAL segment boundary. > > * If a corrupt WAL record is found in archive or streamed from master in > standby mode, throw WARNING instead of PANIC, and keep trying. In > archive recovery (ie. standby_mode=off) it's still a PANIC. We can make > it a WARNING too, which gives the pre-9.0 behavior of starting up the > server on corruption. I prefer PANIC but the discussion is still going on. Seems reasonable for me. > * Small code changes to handling of failedSources, inspired by your > comment. No change in functionality. > > This is also available in my git repository at > git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges" I looked the patch and was not able to find any big problems until now. The attached small patch fixes the typo. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center --001485f5eaca29aad30482ad610f Content-Type: application/octet-stream; name="typo.patch" Content-Disposition: attachment; filename="typo.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g78jp9fg1 KioqIGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZy5jCi0tLSBiL3NyYy9iYWNrZW5k L2FjY2Vzcy90cmFuc2FtL3hsb2cuYwoqKioqKioqKioqKioqKioKKioqIDUzNSw1NDEgKioqKiBz dGF0aWMgaW50IFhMb2dGaWxlUmVhZEFueVRMSSh1aW50MzIgbG9nLCB1aW50MzIgc2VnLCBpbnQg ZW1vZGUsCiAgCQkJCSAgIGludCBzb3VyY2VzKTsKICBzdGF0aWMgYm9vbCBYTG9nUGFnZVJlYWQo WExvZ1JlY1B0ciAqUmVjUHRyLCBpbnQgZW1vZGUsIGJvb2wgZmV0Y2hpbmdfY2twdCwKICAJCQkg Ym9vbCByYW5kQWNjZXNzKTsKISBzdGF0aWMgaW50IGVtb2RlX2Zvcl9jb3JydXB0X3JlY29yZChp bnQgZW5kb2Z3YWxtb2RlKTsKICBzdGF0aWMgdm9pZCBYTG9nRmlsZUNsb3NlKHZvaWQpOwogIHN0 YXRpYyBib29sIFJlc3RvcmVBcmNoaXZlZEZpbGUoY2hhciAqcGF0aCwgY29uc3QgY2hhciAqeGxv Z2ZuYW1lLAogIAkJCQkJY29uc3QgY2hhciAqcmVjb3Zlcm5hbWUsIG9mZl90IGV4cGVjdGVkU2l6 ZSk7Ci0tLSA1MzUsNTQxIC0tLS0KICAJCQkJICAgaW50IHNvdXJjZXMpOwogIHN0YXRpYyBib29s IFhMb2dQYWdlUmVhZChYTG9nUmVjUHRyICpSZWNQdHIsIGludCBlbW9kZSwgYm9vbCBmZXRjaGlu Z19ja3B0LAogIAkJCSBib29sIHJhbmRBY2Nlc3MpOwohIHN0YXRpYyBpbnQgZW1vZGVfZm9yX2Nv cnJ1cHRfcmVjb3JkKGludCBlbW9kZSk7CiAgc3RhdGljIHZvaWQgWExvZ0ZpbGVDbG9zZSh2b2lk KTsKICBzdGF0aWMgYm9vbCBSZXN0b3JlQXJjaGl2ZWRGaWxlKGNoYXIgKnBhdGgsIGNvbnN0IGNo YXIgKnhsb2dmbmFtZSwKICAJCQkJCWNvbnN0IGNoYXIgKnJlY292ZXJuYW1lLCBvZmZfdCBleHBl Y3RlZFNpemUpOwoqKioqKioqKioqKioqKioKKioqIDkwNjUsOTA3MSAqKioqIHRyaWdnZXJlZDoK ICAgKgogICAqICdlbW9kZScgaXMgdGhlIGVycm9yIG1vZGUgdGhhdCB3b3VsZCBiZSB1c2VkIHRv IHJlcG9ydCBhIGZpbGUtbm90LWZvdW5kCiAgICogb3IgbGVnaXRpbWF0ZSBlbmQtb2YtV0FMIHNp dHVhdGlvbi4gSXQgaXMgdXBncmFkZWQgdG8gV0FSTklORyBvciBQQU5JQwohICAqIGlmIHRoZSBh biBjb3JydXB0IHJlY29yZCBpcyBub3QgZXhwZWN0ZWQgYXQgdGhpcyBwb2ludC4KICAgKi8KICBz dGF0aWMgaW50CiAgZW1vZGVfZm9yX2NvcnJ1cHRfcmVjb3JkKGludCBlbW9kZSkKLS0tIDkwNjUs OTA3MSAtLS0tCiAgICoKICAgKiAnZW1vZGUnIGlzIHRoZSBlcnJvciBtb2RlIHRoYXQgd291bGQg YmUgdXNlZCB0byByZXBvcnQgYSBmaWxlLW5vdC1mb3VuZAogICAqIG9yIGxlZ2l0aW1hdGUgZW5k LW9mLVdBTCBzaXR1YXRpb24uIEl0IGlzIHVwZ3JhZGVkIHRvIFdBUk5JTkcgb3IgUEFOSUMKISAg KiBpZiBhIGNvcnJ1cHQgcmVjb3JkIGlzIG5vdCBleHBlY3RlZCBhdCB0aGlzIHBvaW50LgogICAq LwogIHN0YXRpYyBpbnQKICBlbW9kZV9mb3JfY29ycnVwdF9yZWNvcmQoaW50IGVtb2RlKQo= --001485f5eaca29aad30482ad610f--