Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 6BCA7632644 for ; Tue, 30 Mar 2010 23:01:52 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 30023-02 for ; Wed, 31 Mar 2010 02:01:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-gx0-f227.google.com (mail-gx0-f227.google.com [209.85.217.227]) by mail.postgresql.org (Postfix) with ESMTP id E58CA6325D0 for ; Tue, 30 Mar 2010 23:01:41 -0300 (ADT) Received: by gxk27 with SMTP id 27so5260764gxk.1 for ; Tue, 30 Mar 2010 19:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=lVn0TuVLXWqqEIYXckUm0s7rIAbfT75gRgzivH8DDkg=; b=HtvWURivA6YcKzLKSCtjVKLHuAfPAilTD67VnBJNEAAa7sppOleZh+kXRv9Z9M/rBu RihbGHOOMNOyVl+6DINAF7OfLPbAVyT6wAxbBiAus/C4FwiI4ocJ6QCoKKZTcySJzsbW MYZADTRQwS8MXV2W33wvbH+GcDCHXripXQFbU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=meYX0xjHi6Hy76BiP39p7Kcz3R6375qcPBaHoC5RF8VOHXFvL50w9RbjWkiYlWiCZl na5OI+IpzGixCHG5z65xgQ1cgys8+VLSfS+Dqgt4OWIcnHdgKXwRZSR8BokRo2YJdxiQ 9gHSPIrniB/tw0OqxabLOKV5AyNZl6cQ4PIHI= MIME-Version: 1.0 Received: by 10.100.253.9 with HTTP; Tue, 30 Mar 2010 19:01:40 -0700 (PDT) In-Reply-To: <4BB226AC.4020205@enterprisedb.com> References: <3f0b79eb1002092105r21e009d3v468496058ba04392@mail.gmail.com> <1268988724.3556.3.camel@ebony> <4BA361E4.7020309@enterprisedb.com> <3f0b79eb1003230017v16f4ecbeyc20e75beeffe8f1c@mail.gmail.com> <4BAA060A.2020000@enterprisedb.com> <3f0b79eb1003240620h209a0a40ud2063728b5db31a6@mail.gmail.com> <3f0b79eb1003240636y6ba3d739idc4555f88c98e32e@mail.gmail.com> <4BAB5D4E.4000009@enterprisedb.com> <3f0b79eb1003252224u9b91cc4la75547c6a2610ffc@mail.gmail.com> <4BB226AC.4020205@enterprisedb.com> Date: Wed, 31 Mar 2010 11:01:40 +0900 Received: by 10.101.176.25 with SMTP id d25mr5687207anp.156.1270000900188; Tue, 30 Mar 2010 19:01:40 -0700 (PDT) Message-ID: <3f0b79eb1003301901l56ce9daep9aef265e83ae59f1@mail.gmail.com> Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL From: Fujii Masao To: Heikki Linnakangas Cc: Simon Riggs , Aidan Van Dyk , PostgreSQL-development Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201003/1243 X-Sequence-Number: 160019 On Wed, Mar 31, 2010 at 1:28 AM, Heikki Linnakangas wrote: > Fujii Masao wrote: >>> * Small code changes to handling of failedSources, inspired by your >>> comment. No change in functionality. >>> >>> This is also available in my git repository at >>> git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges" >> >> I looked the patch and was not able to find any big problems until now. >> The attached small patch fixes the typo. > > Thanks. Committed with that typo-fix, and I also added a comment > explaining how failedSources and retrying XLogPageRead() works. Great! Thanks a lot! This change affects various recovery patterns that we support now. For example, normal crash recovery, archive recovery, recovery using pg_standby, recovery in standby mode, and so on. So we would need to test whether all of those patterns work fine with the change. I'll do it as much as possible. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center