X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.2]) by svr1.postgresql.org (Postfix) with ESMTP id ED2EFD1B8B7 for ; Thu, 4 Mar 2004 23:24:46 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024) with ESMTP id 87526-03 for ; Thu, 4 Mar 2004 19:24:45 -0400 (AST) Received: from smtp013.mail.yahoo.com (smtp013.mail.yahoo.com [216.136.173.57]) by svr1.postgresql.org (Postfix) with SMTP id 69D73D1BA53 for ; Thu, 4 Mar 2004 19:24:42 -0400 (AST) Received: from unknown (HELO europa.janwieck.net) (janwieck@68.80.245.191 with login) by smtp013.mail.yahoo.com with SMTP; 4 Mar 2004 23:24:44 -0000 Received: from Yahoo.com (pcp01341166pcs.wilog301.pa.comcast.net [68.80.245.191]) (authenticated) by europa.janwieck.net (8.11.6/8.11.6) with ESMTP id i24NOGj06892; Thu, 4 Mar 2004 18:24:21 -0500 Message-ID: <4047BA9B.3010302@Yahoo.com> Date: Thu, 04 Mar 2004 18:24:11 -0500 From: Jan Wieck User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tom Lane Cc: Fabien COELHO , Bruce Momjian , PostgreSQL Patches Subject: Re: "ALSO" keyword to "CREATE RULE" patch References: <200403031903.i23J3Fx14760@candle.pha.pa.us> <25495.1078411608@sss.pgh.pa.us> In-Reply-To: <25495.1078411608@sss.pgh.pa.us> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200403/49 X-Sequence-Number: 9980 Tom Lane wrote: > Fabien COELHO writes: >> Most of the patch deals with the documentation, which is rather ugly >> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there >> is no name for the default behavior. I think "ALSO" fixes this issue as it >> clarifies the explanations. > > Hmm ... I find that argument much more convincing than any of the others > ... > > Jan, what do you think? You invented this command's syntax IIRC. I did not. We inherited it from Postgres 4.2. If people think an ALSO keyword will clearify things, what about renaming the whole CREATE RULE into something along the line CREATE QUERY REWRITE MACRO? Jan -- #======================================================================# # It's easier to get forgiveness for being wrong than for being right. # # Let's break this rule - forgive me. # #================================================== JanWieck@Yahoo.com #