X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.2]) by svr1.postgresql.org (Postfix) with ESMTP id 34B0FD1C96B for ; Fri, 5 Mar 2004 00:09:10 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024) with ESMTP id 99594-02 for ; Thu, 4 Mar 2004 20:09:09 -0400 (AST) Received: from smtp014.mail.yahoo.com (smtp014.mail.yahoo.com [216.136.173.58]) by svr1.postgresql.org (Postfix) with SMTP id B35D8D1C968 for ; Thu, 4 Mar 2004 20:09:05 -0400 (AST) Received: from unknown (HELO europa.janwieck.net) (janwieck@68.80.245.191 with login) by smtp014.mail.yahoo.com with SMTP; 5 Mar 2004 00:09:08 -0000 Received: from Yahoo.com (pcp01341166pcs.wilog301.pa.comcast.net [68.80.245.191]) (authenticated) by europa.janwieck.net (8.11.6/8.11.6) with ESMTP id i25095j07004; Thu, 4 Mar 2004 19:09:05 -0500 Message-ID: <4047C4F3.4000608@Yahoo.com> Date: Thu, 04 Mar 2004 19:08:19 -0500 From: Jan Wieck User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bruce Momjian Cc: Tom Lane , Fabien COELHO , PostgreSQL Patches Subject: Re: "ALSO" keyword to "CREATE RULE" patch References: <200403042331.i24NVs913028@candle.pha.pa.us> In-Reply-To: <200403042331.i24NVs913028@candle.pha.pa.us> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200403/53 X-Sequence-Number: 9984 Bruce Momjian wrote: > Jan Wieck wrote: >> Tom Lane wrote: >> >> > Fabien COELHO writes: >> >> Most of the patch deals with the documentation, which is rather ugly >> >> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there >> >> is no name for the default behavior. I think "ALSO" fixes this issue as it >> >> clarifies the explanations. >> > >> > Hmm ... I find that argument much more convincing than any of the others >> > ... >> > >> > Jan, what do you think? You invented this command's syntax IIRC. >> >> I did not. We inherited it from Postgres 4.2. If people think an ALSO >> keyword will clearify things, what about renaming the whole CREATE RULE >> into something along the line CREATE QUERY REWRITE MACRO? > > Are you saying you don't want ALSO added? > No, I am saying that CREATE RULE is so often misinterpreted to work like a trigger and when we explain that it is more like Macro expansion before the query is executed they understand better. CREATE RULE itself is just vague, with or without ALSO. Jan -- #======================================================================# # It's easier to get forgiveness for being wrong than for being right. # # Let's break this rule - forgive me. # #================================================== JanWieck@Yahoo.com #