public inbox for [email protected]  

help / color / mirror / Atom feed
From: Jonathan S. Katz <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: R Ransbottom <[email protected]>
Cc: Ian Barwick <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Laurenz Albe <[email protected]>
Cc: Pg Docs <[email protected]>
Subject: Re: Documentation: 21.5. Default Roles
Date: Tue, 28 Apr 2020 16:02:25 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABUevEwYMVbqMi7fe7n40PeFtj0meNjpP4rx=HwJO8Ef8kj75g@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CABUevEzrCyxVx2CMCObt76ZuwnTtwskSjZUJcxEFzNaVcFJ5tw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CABUevEwYMVbqMi7fe7n40PeFtj0meNjpP4rx=HwJO8Ef8kj75g@mail.gmail.com>

On 4/28/20 2:19 PM, Magnus Hagander wrote:
> On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz <[email protected]
> <mailto:[email protected]>> wrote:
> 
>     On 4/9/20 11:45 PM, Bruce Momjian wrote:
>     > On Thu, Apr  9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote:
>     >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
>     >>> Jonathan, Stephen, with the minor release done, can we focus on
>     adding
>     >>> the URL redirect and completing the patch to rename this feature
>     in the
>     >>> docs?  Thanks.
>     >>
>     >> Yes, I have a prototype for this ready, which I had scrambled
>     together
>     >> before the release. I am happy to make it committable in the
>     coming days.
>     >
>     > Thanks.  Once that is done Stephen can apply my patch with his
>     > additions.
> 
>     Please see attached patch for pgweb that allows for the documentation to
>     be redirected from a page that is removed to a newer page. The way
>     it works:
> 
>     - Checks to see if a page is found. If it is, great!
>     - Now if a page 404s, we first check to see if there is a forwarding
>     address, i.e. the new page. If it is, we issue a 301 (permanent
>     redirecTt).
>     - If it's still not found, we abort.
> 
>     I believe this gives us the desired behavior.
> 
>     Thoughts on the patch?
> 
> 
>  Looks good to me. Go for it.

This is deployed. Ready for the patch in core.

Thanks!

Jonathan



Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (45+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Documentation: 21.5. Default Roles
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox