X-Original-To: pgsql-hackers-postgresql.org@postgresql.org Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id 224AE9FB224 for ; Wed, 2 Aug 2006 00:47:53 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 87091-07 for ; Wed, 2 Aug 2006 00:47:43 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey- Received: from joeconway.com (joeconway.com [68.15.9.201]) by postgresql.org (Postfix) with ESMTP id BA5F69FACFE for ; Wed, 2 Aug 2006 00:47:43 -0300 (ADT) Received: from [192.168.4.40] (account jconway [192.168.4.40] verified) by joeconway.com (CommuniGate Pro SMTP 4.1.8) with ESMTP-TLS id 4138167; Tue, 01 Aug 2006 20:47:42 -0700 Message-ID: <44D0205E.9060300@joeconway.com> Date: Tue, 01 Aug 2006 20:47:42 -0700 From: Joe Conway User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.13) Gecko/20060501 Fedora/1.7.13-1.1.fc5 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bruce Momjian CC: Tom Lane , "Hackers (PostgreSQL)" Subject: Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] References: <200608020314.k723EbQ01079@momjian.us> In-Reply-To: <200608020314.k723EbQ01079@momjian.us> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.011 tagged_above=0 required=5 tests=AWL, SPF_HELO_PASS, SPF_PASS X-Spam-Level: X-Archive-Number: 200608/66 X-Sequence-Number: 87559 Bruce Momjian wrote: > Should we wait for someone to actually ask for this before adding it > to the TODO list? Probably worth adding it to the TODO list so it doen't get lost. > Does it cause a crash now? Nope: regression=# create table log(f1 int, f2 int, tag text); CREATE TABLE regression=# insert into src values(1,2); INSERT 0 1 regression=# create rule r2 as on update to src do insert into log values(old.*, 'old'), (new.*, 'new'); ERROR: VALUES must not contain OLD or NEW references Joe