pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedPatch for some typos in pgarchivecleanup.sgml
3+ messages / 3 participants
[nested] [flat]
* Patch for some typos in pgarchivecleanup.sgml
@ 2010-08-11 05:25 Satoshi Nagayasu <satoshi.nagayasu@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Satoshi Nagayasu @ 2010-08-11 05:25 UTC (permalink / raw)
To: pgsql-docs
Hi all,
I found some typos in pgarchivecleanup.sgml.
A patch to fix them is attached in this mail.
Please take a look.
Regards,
--
NAGAYASU Satoshi <satoshi.nagayasu@gmail.com>
Attachments:
pgarchivecleanup.sgml.cvs.patch (text/plain, 823B) download
Index: pgarchivecleanup.sgml
===================================================================
--- pgarchivecleanup.sgml (revision 404)
+++ pgarchivecleanup.sgml (working copy)
@@ -106,7 +106,7 @@
<para>On Linux or Unix systems, you might use:
<programlisting>
-archive_cleanup_command = 'pg_archivecleanup -d .../archive %r 2>>cleanup.log'
+archive_cleanup_command = 'pg_archivecleanup -d ../archive %r 2>>cleanup.log'
</programlisting>
where the archive directory is physically located on the standby server,
so that the <literal>archive_command</> is accessing it across NFS,
@@ -116,7 +116,7 @@
<itemizedlist>
<listitem>
<para>
- produce debugging output in <filename>standby.log</>
+ produce debugging output in <filename>cleanup.log</>
</para>
</listitem>
<listitem>
* Re: Patch for some typos in pgarchivecleanup.sgml
@ 2010-08-11 08:26 Fujii Masao <masao.fujii@gmail.com>
parent: Satoshi Nagayasu <satoshi.nagayasu@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Fujii Masao @ 2010-08-11 08:26 UTC (permalink / raw)
To: Satoshi Nagayasu <satoshi.nagayasu@gmail.com>; +Cc: pgsql-docs
2010/8/11 Satoshi Nagayasu <satoshi.nagayasu@gmail.com>:
> I found some typos in pgarchivecleanup.sgml.
> A patch to fix them is attached in this mail.
> Please take a look.
-archive_cleanup_command = 'pg_archivecleanup -d .../archive %r 2>>cleanup.log'
+archive_cleanup_command = 'pg_archivecleanup -d ../archive %r 2>>cleanup.log'
This is not a typo. Triple dots ... is used as replaceable part of the path,
and is used also elsewhere. Though I agree that's somewhat confusing.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Patch for some typos in pgarchivecleanup.sgml
@ 2010-08-15 20:23 Tom Lane <tgl@sss.pgh.pa.us>
parent: Fujii Masao <masao.fujii@gmail.com>
0 siblings, 0 replies; 3+ messages in thread
From: Tom Lane @ 2010-08-15 20:23 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@gmail.com>; +Cc: Satoshi Nagayasu <satoshi.nagayasu@gmail.com>; pgsql-docs
Fujii Masao <masao.fujii@gmail.com> writes:
> 2010/8/11 Satoshi Nagayasu <satoshi.nagayasu@gmail.com>:
>> -archive_cleanup_command = 'pg_archivecleanup -d .../archive %r 2>>cleanup.log'
>> +archive_cleanup_command = 'pg_archivecleanup -d ../archive %r 2>>cleanup.log'
> This is not a typo. Triple dots ... is used as replaceable part of the path,
> and is used also elsewhere. Though I agree that's somewhat confusing.
It seems unnecessary to use that convention here, though. I changed it
to read "/mnt/standby/archive", which is consistent with some other
examples in which an NFS mount is assumed.
The standby.log -> cleanup.log change is an obvious typo, in any case.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2010-08-15 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-08-11 05:25 Patch for some typos in pgarchivecleanup.sgml Satoshi Nagayasu <satoshi.nagayasu@gmail.com>
2010-08-11 08:26 ` Fujii Masao <masao.fujii@gmail.com>
2010-08-15 20:23 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox