Received: from localhost (unknown [200.46.204.191]) by postgresql.org (Postfix) with ESMTP id D30E59F9C90 for ; Mon, 3 Sep 2007 11:54:37 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.191]) (amavisd-maia, port 10024) with ESMTP id 09437-08 for ; Mon, 3 Sep 2007 11:54:32 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.5 Received: from ironport2-out.pppoe.ca (ironport2-out.pppoe.ca [206.248.154.182]) by postgresql.org (Postfix) with ESMTP id 09F859F9C4B for ; Mon, 3 Sep 2007 11:54:32 -0300 (ADT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CAEK920bO+Igp/2dsb2JhbAA X-IronPort-AV: E=Sophos;i="4.20,202,1186372800"; d="scan'208";a="5943987" Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 03 Sep 2007 10:54:28 -0400 Received: from [206.248.136.41] ([206.248.136.41]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id IXF23829; Mon, 03 Sep 2007 10:54:29 -0400 Message-ID: <46DC2024.4010509@mark.mielke.cc> Date: Mon, 03 Sep 2007 10:54:28 -0400 From: Mark Mielke User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: Tom Lane CC: Gregory Stark , Magnus Hagander , Oleg Bartunov , Pavel Stehule , PostgreSQL Hackers Subject: Re: tsearch filenames unlikes special symbols and numbers References: <162867790709021328i7771aa9jfe79268bccbf123d@mail.gmail.com> <18259.1188773171@sss.pgh.pa.us> <87y7foir7t.fsf@oxford.xeocode.com> <19257.1188777110@sss.pgh.pa.us> <87tzqci6tp.fsf@oxford.xeocode.com> <20070903075609.GD21833@svr2.hagander.net> <1692.1188826039@sss.pgh.pa.us> <87zm03zwqs.fsf@oxford.xeocode.com> <8195.1188828543@sss.pgh.pa.us> In-Reply-To: <8195.1188828543@sss.pgh.pa.us> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200709/89 X-Sequence-Number: 107241 Tom Lane wrote: > Also, ____ says that Windows throws an error for ":" in the filename, > which means we needn't. > > Windows doesn't fail - but it can do odd things. For example, try: C:\> echo hi >foo:bar If one then checks the directory, one finds a "foo". Depending on *which* API one uses, the rules may change around a bit - but whatever the situation, as long as you prefix it with a valid path, the ":" is not going to cause you problems. > It might still be a good idea to restrict the names to be SQL > identifiers (ie, alphanumerics and underscores) for future-proofing, > but it wasn't clear whether anyone but me thought that was a good > argument. I'm willing to make it just be no-dir-separators. > I think it is a good argument. Cheers, mark -- Mark Mielke