Message-ID: <47ed4ed1-2d33-4e0d-afec-185ac75f43e4@gmail.com>
Date: Sun, 7 Jun 2026 15:40:37 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Correct the version sent in protocol negotiation
To: Laurenz Albe <laurenz.albe@cybertec.at>, pgsql-docs@lists.postgresql.org
References: <065b1b54-dc4a-4a29-919d-76f89ce96532@gmail.com>
 <f3b25f9c1d383c37cb2d772b430e8ca5103905d2.camel@cybertec.at>
Content-Language: en-US
From: Ning Sun <classicning@gmail.com>
Autocrypt: addr=classicning@gmail.com; keydata=
 xsBNBFLot3sBCAC9j9CSDztY1mrFV4KkJjNp1HEuLpZnl/EDJKc+omEixTOWuE81R+YOBCV2
 e4f3w4ZZHxkJ5n57by1GUPDyMG4bBC3I27jeiGKz88D/6HmTRww2Z/amUJYB/RO8vOMzbO8+
 m4VnzrHwZe5qqFaw3AId+tF6+cehh8/Um61IlRsN0FGsyAJBox5FnnQAuGfRnUFypRVsrF3c
 iH5aweJVasl61nPxBAVw5WyPzvDqhnNhIT71nFr/94q7R8kjX/BrQ92cXPpLdzUO6AnNH3eD
 dGU7Jj/A63HCthVamZ6u7FgqcZLl1wZfdi+kJnlDnYTYVP1xpIXM2W5xkZWQcVU9/WlPABEB
 AAHNLk5pbmcgU3VuIChHb29nbGUgbWFpbCkgPGNsYXNzaWNuaW5nQGdtYWlsLmNvbT7CwI4E
 EwEIADgCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AWIQTtkdI0yulzZ5rUbqYuJ+IPxN7q
 PgUCZwVVIwAKCRAuJ+IPxN7qPvjIB/9ra9tReBTZUxYBGAv9k0ZEHpL9fhqwDLl1k+zGXwei
 h2Ty8UPAKKJ6QCGid5GTG8k4Em+zctf63whCKF350/a8VLzmEW/WFTP2lzmH7aRsSeguOYGn
 0azgE8y6RFwjRXAz4QLPR9uVOPhmQkFU0Qjfu+w3pJxmkmMqSmMcu6C44cICibSj3bt2DpWh
 e3r1yQUInJgCeM+IRdEICMjyGiY5O2rHr/IjCygf8Ya79kqSsfd6bu+IcKT230k8A+mbA7Pp
 OwwxAPdETIrHgW8yIZxFkz5JC0P4O4CdKvQNNOrBbFPuZyM8cSmIM4AQizwrGBQPG6uYnGXO
 8TkRtAcXPQZyzsBNBFepeMsBCADRNmte4eN4W/r72nzR4SVHEMJPBAaT1+DyJZ8Vk3f+g1l1
 PTlsESLLg2pJD0HvsdAith/dedhlf5+wFujl2CXvmF16gD1MYEcuDqQnjRwQb67qn3f3FIyZ
 Wheoa30cAN3G02eFLZoRlGZ08rHOhbt+wielOvrFSUA5jZMNpIQF9VlOYg46aE1lOHbsY42u
 AbOJq3FxTvtxWyxHA/PIrHu+eqzL4fS+bgYm8o5SFK/DQNhhfK3bw0f1TANKLHD0W65NI3BS
 P7FKQC4QnStADh2d+qupEDlRQpC5+Wi+OaSujHKLMsz6vci8nz6/6Ki7n3qiOLjsXoOBGeVg
 USX+iTL3ABEBAAHCwF8EGAEIAAkFAlepeMsCGwwACgkQLifiD8Te6j4MBgf+NMZ7/zcnDMHf
 w/D0huW7h9wNDbipS+T+gEwKU1ILt/FDnws7+cktFHWETFsjlAkSSincBXK+kSOF10FKaLP6
 Z/7GxOigC9g8PsImCrNIyYTc64DEKXmA8xUou2SUbbh4M2/lIAVhre2t8NbwtTZD7BaBbdSp
 WPETU7DCDbm1TZ3tzRvYTPqtIOWKgganBipNyk6QgV3PkkDmJykPotjlOqyWV50Kugk6X3I1
 kMoU67+5GTUt3XBiM0fxMyay6OCb2dfRwUirOYHXpIhW2nULjxGjpFCEMl6hVRSt99tLZhpo
 Ux0a6Fn6ug0F6kJYHfurJqo055cKbqfGjIFlcenqHg==
In-Reply-To: <f3b25f9c1d383c37cb2d772b430e8ca5103905d2.camel@cybertec.at>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/47ed4ed1-2d33-4e0d-afec-185ac75f43e4%40gmail.com>
Precedence: bulk

I see. The "minor version"  has its own meaning in postgres context.

That makes sense. Thank you for clarification, Laurenz.

On 07/06/2026 13:06, Laurenz Albe wrote:
> On Sun, 2026-06-07 at 10:00 +0800, Ning Sun wrote:
>> Our protocol doc describes protocol negotiation message will send latest
>> minor version. However that field is a 4-byte one. The actual
>> implementation sends full version including the major part:
>>
>> The patch included just clarifies this behavior by removing "minor" from
>> "newest minor version".
> To my understanding, the "minor version" is the entire version *including*
> the last number, like 18.4 (and not only .4).
>
> In this, I seem to be in agreement with
> https://www.postgresql.org/support/versioning/
>
> To me, removing the "minor" makes the text less clear.  If we change that
> at all, perhaps a wording like "the full version, including the minor
> release" would remove any ambiguity.
>
> Yours,
> Laurenz Albe