Message-ID: <48125106de1a275b1e0c2d46b7c0a56a2b0675cb.camel@cybertec.at>
Subject: Re: Mention invalid null byte sequence
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: bugs-postgresql@antipoul.fr, pgsql-docs@lists.postgresql.org
Date: Tue, 08 Dec 2020 11:34:15 +0100
In-Reply-To: <3153759.1607372842@sss.pgh.pa.us>
References: <160720552914.710.16625261471128631268@wrigleys.postgresql.org>
	 <0f0470f6d8c543793d2b71913cb230daea1aef3a.camel@cybertec.at>
	 <3153759.1607372842@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2020-12-07 at 15:27 -0500, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > On Sat, 2020-12-05 at 21:58 +0000, PG Doc comments form wrote:
> > > The following documentation comment has been logged on the website:
> > > Page: https://www.postgresql.org/docs/13/datatype-character.html
> > > Description:
> > > 
> > > So it should written in the character type that null byte are not accepted,
> > > it would make like easier to migrate to PostgreSQL :)
> >
> > +1; how about the attached patch?
> 
> I had thought that this was already documented, but after digging around
> I can only find it mentioned in the contexts of saying that literal
> strings and quoted identifiers can't contain \0.  So yeah, we need to
> improve that.
> 
> I agree with the submitter that the place one would expect to read about
> this is in datatype-character.html.  So I'd propose the attached.
> Maybe there's reason to repeat the info in charset.sgml, but it seems
> like more of a datatype limitation than a character set issue.

+1 on your patch.

Yours,
Laurenz Albe