Received: from maia.hub.org (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id D9244632FC0 for ; Thu, 25 Feb 2010 13:22:35 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 78812-01-4 for ; Thu, 25 Feb 2010 17:22:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qy0-f178.google.com (mail-qy0-f178.google.com [209.85.221.178]) by mail.postgresql.org (Postfix) with ESMTP id 3BC0E634729 for ; Thu, 25 Feb 2010 13:21:49 -0400 (AST) Received: by qyk8 with SMTP id 8so1122695qyk.4 for ; Thu, 25 Feb 2010 09:21:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=WHl6pwJIqbGX7wQV6pX9ENNdlrcBECeigm1FmPjliUg=; b=wd5SFBvWzn0OPl0i2EZO9bJgulYWBkbv8cBWf089EDWOQKkQtLlNe/DyzYksZkihhF e4WqS+8m2fn1Kx3pzwfD8Yhv/bRKXtSLWZkAGxpMN4ev9cNfMJChu6W7mdRQl6lsWycl 8JOzl69u9Ni7oFkGZPfG4L3JusrXm7/J9lVTs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=rEZep4Wasa0lGSMXWzCfJAKA2o/TWImTOb+FkaIM+sKYUenIugARDG6be1Zvg3Hjdk /X05EINTUHE/5r7AfZkxQZRkXI1cm8LM37EgJ0CkBEw20IafxMG6SfCVsDrESGmAazcp ejIQTLsG4YDqI/NQxWvpLu5EOCq2jLuUPLYDg= MIME-Version: 1.0 Received: by 10.229.217.141 with SMTP id hm13mr1002451qcb.48.1267118506399; Thu, 25 Feb 2010 09:21:46 -0800 (PST) In-Reply-To: <18812.1267067697@sss.pgh.pa.us> References: <48bb92b1002241842h2ee4cc38pf2aee19f3071273e@mail.gmail.com> <18812.1267067697@sss.pgh.pa.us> Date: Thu, 25 Feb 2010 09:21:46 -0800 Message-ID: <48bb92b1002250921k3a1ae0a0xab26038ccaae089d@mail.gmail.com> Subject: Re: [PATCH] log_statement docs From: gabrielle To: Tom Lane Cc: pgsql-docs@postgresql.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.227 tagged_above=-10 required=5 tests=AWL=0.372, BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201002/42 X-Sequence-Number: 5358 On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane wrote: > gabrielle writes: >> Patch amends description of log_statement to include definition of "all" option. > > Shouldn't it just say "all means all", if we think that needs to be > explained? I think it should say something about the "all" option. I read & re-read that section trying to figure out what the difference between "mod" and "all" was, and finally asked on the irc channel. As it stands, it essentially says "there are three options to this command, but we're only going to tell you about two of them." :) Thanks! gabrielle