pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedDISTINCT term in aggregate function
2+ messages / 2 participants
[nested] [flat]
* DISTINCT term in aggregate function
@ 2021-03-18 18:03 Pantelis Theodosiou <ypercube@gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: Pantelis Theodosiou @ 2021-03-18 18:03 UTC (permalink / raw)
To: Tomas Vondra <tomas.vondra@enterprisedb.com>; pgsql-docs@lists.postgresql.org
Hi, I didn't think of including you in this suggestion.
Or the pdsql-docs was not the right list to post? I didn't want to mix it
with the GROUP BY DISTINCT patch.
Please check my suggestion.
Best regards
Pantelis Theodosiou
---------- Forwarded message ---------
From: Pantelis Theodosiou <ypercube@gmail.com>
Date: Sat, Mar 13, 2021 at 1:03 AM
Subject: Fwd: GROUP BY DISTINCT
To: <pgsql-docs@lists.postgresql.org>
---------- Forwarded message ---------
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
Date: Fri, Mar 12, 2021 at 11:33 PM
Subject: Re: GROUP BY DISTINCT
To: Vik Fearing <vik@postgresfriends.org>, Georgios Kokolatos <
gkokolatos@protonmail.com>, <pgsql-hackers@lists.postgresql.org>
Cc: Erik Rijkers <er@xs4all.nl>
Hi Vik,
The patch seems quite ready, I have just two comments.
1) Shouldn't this add another <indexterm> for DISTINCT, somewhere in the
documentation? Now the index points just to the SELECT DISTINCT part.
.....
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
After reading the above thread in hackers, I noticed that the index does
not point to aggrgeate functions either and DISTINCT is not mentioned in
the aggregate functions page either:
https://www.postgresql.org/docs/current/functions-aggregate.html
Shouldn't it be mentioned with an example of COUNT(DISTINCT ...) or
aggregate_function(DISTINCT ...) in general ?
Best regards
Pantelis Theodosiou
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: DISTINCT term in aggregate function
@ 2021-03-18 18:05 Tomas Vondra <tomas.vondra@enterprisedb.com>
parent: Pantelis Theodosiou <ypercube@gmail.com>
0 siblings, 0 replies; 2+ messages in thread
From: Tomas Vondra @ 2021-03-18 18:05 UTC (permalink / raw)
To: Pantelis Theodosiou <ypercube@gmail.com>; pgsql-docs@lists.postgresql.org
Sorry, I'm not reading pgsql-docs very often, so I missed the post.
Yeah, we should probably add an indexterm to the other places too.
regards
On 3/18/21 7:03 PM, Pantelis Theodosiou wrote:
> Hi, I didn't think of including you in this suggestion.
> Or the pdsql-docs was not the right list to post? I didn't want to mix
> it with the GROUP BY DISTINCT patch.
>
> Please check my suggestion.
>
> Best regards
> Pantelis Theodosiou
>
>
>
>
> ---------- Forwarded message ---------
> From: *Pantelis Theodosiou* <ypercube@gmail.com <mailto:ypercube@gmail.com>>
> Date: Sat, Mar 13, 2021 at 1:03 AM
> Subject: Fwd: GROUP BY DISTINCT
> To: <pgsql-docs@lists.postgresql.org
> <mailto:pgsql-docs@lists.postgresql.org>>
>
>
>
> ---------- Forwarded message ---------
> From: *Tomas Vondra* <tomas.vondra@enterprisedb.com
> <mailto:tomas.vondra@enterprisedb.com>>
> Date: Fri, Mar 12, 2021 at 11:33 PM
> Subject: Re: GROUP BY DISTINCT
> To: Vik Fearing <vik@postgresfriends.org
> <mailto:vik@postgresfriends.org>>, Georgios Kokolatos
> <gkokolatos@protonmail.com <mailto:gkokolatos@protonmail.com>>,
> <pgsql-hackers@lists.postgresql.org
> <mailto:pgsql-hackers@lists.postgresql.org>>
> Cc: Erik Rijkers <er@xs4all.nl <mailto:er@xs4all.nl>>
>
>
> Hi Vik,
>
> The patch seems quite ready, I have just two comments.
>
> 1) Shouldn't this add another <indexterm> for DISTINCT, somewhere in the
> documentation? Now the index points just to the SELECT DISTINCT part.
>
> .....
>
> regards
>
> --
> Tomas Vondra
> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com;
> The Enterprise PostgreSQL Company
>
>
>
> After reading the above thread in hackers, I noticed that the index does
> not point to aggrgeate functions either and DISTINCT is not mentioned in
> the aggregate functions page
> either: https://www.postgresql.org/docs/current/functions-aggregate.html
> <https://www.postgresql.org/docs/current/functions-aggregate.html;
> Shouldn't it be mentioned with an example of COUNT(DISTINCT ...) or
> aggregate_function(DISTINCT ...) in general ?
>
> Best regards
>
> Pantelis Theodosiou
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-03-18 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 18:03 DISTINCT term in aggregate function Pantelis Theodosiou <ypercube@gmail.com>
2021-03-18 18:05 ` Tomas Vondra <tomas.vondra@enterprisedb.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox