pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

Inaccurate comment for information_schema.triggered_update_columns
2+ messages / 2 participants
[nested] [flat]

* Inaccurate comment for information_schema.triggered_update_columns
@ 2010-10-18 23:56  Josh Kupershmidt <schmiddy@gmail.com>
  0 siblings, 1 reply; 2+ messages in thread

From: Josh Kupershmidt @ 2010-10-18 23:56 UTC (permalink / raw)
  To: pgsql-docs

Hi,

It looks like this commit:
<http://archives.postgresql.org/pgsql-committers/2009-12/msg00313.php;
implemented a working version of
information_schema.triggered_update_columns, but left in the comment
stating:

  -- PostgreSQL doesn't allow the specification of individual triggered
  -- update columns, so this view is empty.

I think this comment should be removed, as it's no longer accurate.
Patch attached.

Josh

Attachments:

triggered_update_columns_comment.patch (application/octet-stream, 598B) download
diff --git a/src/backend/catalog/information_schema.sql b/src/backend/catalog/information_schema.sql
index f1c9263..cb85f92 100644
*** a/src/backend/catalog/information_schema.sql
--- b/src/backend/catalog/information_schema.sql
*************** GRANT SELECT ON tables TO PUBLIC;
*** 1847,1854 ****
   * TRIGGERED_UPDATE_COLUMNS view
   */
  
- -- PostgreSQL doesn't allow the specification of individual triggered
- -- update columns, so this view is empty.
  
  CREATE VIEW triggered_update_columns AS
      SELECT CAST(current_database() AS sql_identifier) AS trigger_catalog,
--- 1847,1852 ----


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Inaccurate comment for information_schema.triggered_update_columns
@ 2010-10-20 21:07  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Josh Kupershmidt <schmiddy@gmail.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2010-10-20 21:07 UTC (permalink / raw)
  To: Josh Kupershmidt <schmiddy@gmail.com>; +Cc: pgsql-docs

Josh Kupershmidt <schmiddy@gmail.com> writes:
> It looks like this commit:
> <http://archives.postgresql.org/pgsql-committers/2009-12/msg00313.php;
> implemented a working version of
> information_schema.triggered_update_columns, but left in the comment
> stating:

>   -- PostgreSQL doesn't allow the specification of individual triggered
>   -- update columns, so this view is empty.

> I think this comment should be removed, as it's no longer accurate.
> Patch attached.

Applied, thanks.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2010-10-20 21:07 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-10-18 23:56 Inaccurate comment for information_schema.triggered_update_columns Josh Kupershmidt <schmiddy@gmail.com>
2010-10-20 21:07 ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox