Message-ID: <4B73F678.8070109@enterprisedb.com>
Date: Thu, 11 Feb 2010 14:22:16 +0200
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706)
MIME-Version: 1.0
To: Simon Riggs <simon@2ndQuadrant.com>
CC: Fujii Masao <masao.fujii@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously
	retry 	restoring the next WAL
References: <20100127152751.3B2047541B9@cvs.postgresql.org>	
	<3f0b79eb1002092105r21e009d3v468496058ba04392@mail.gmail.com>	
	<4B726120.80007@enterprisedb.com>
	<1265884657.7341.1192.camel@ebony>
In-Reply-To: <1265884657.7341.1192.camel@ebony>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Simon Riggs wrote:
> On Wed, 2010-02-10 at 09:32 +0200, Heikki Linnakangas wrote:
>> Hmm, so after running restore_command, check the file size and if it's
>> too short, treat it the same as if restore_command returned non-zero?
>> And it will be retried on the next iteration. Works for me, though OTOH
>> it will then fail to complain about a genuinely WAL file that's
>> truncated for some reason. I guess there's no way around that, even if
>> you have a script as restore_command that does the file size check, it
>> will have the same problem.
> 
> Are we trying to re-invent pg_standby here?

That's not the goal, but we seem to need some of the same functionality
in the backend now.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com