Message-ID: <4B742069.1000805@enterprisedb.com>
Date: Thu, 11 Feb 2010 17:21:13 +0200
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706)
MIME-Version: 1.0
To: Simon Riggs <simon@2ndQuadrant.com>
CC: Dimitri Fontaine <dfontaine@hi-media.com>,
	Fujii Masao <masao.fujii@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously
	retry 	restoring the next WAL
References: <20100127152751.3B2047541B9@cvs.postgresql.org>	
	<3f0b79eb1002092105r21e009d3v468496058ba04392@mail.gmail.com>	
	<4B726120.80007@enterprisedb.com>
	<1265884657.7341.1192.camel@ebony>	
	<4B73F678.8070109@enterprisedb.com>
	<1265891248.7341.1346.camel@ebony>	
	<4B73FB99.4080403@enterprisedb.com>
	<1265893599.7341.1454.camel@ebony>	
	<877hqjc2kk.fsf@hi-media-techno.com>
	<1265896250.7341.1627.camel@ebony>	
	<4B740C6C.3010607@enterprisedb.com>
	<1265897834.7341.1714.camel@ebony>	
	<4B7412BE.5030605@enterprisedb.com>
	<1265899120.7341.1781.camel@ebony>
In-Reply-To: <1265899120.7341.1781.camel@ebony>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Simon Riggs wrote:
> On Thu, 2010-02-11 at 16:22 +0200, Heikki Linnakangas wrote:
>> Simon Riggs wrote:
>>> Might it not be simpler to add a parameter onto pg_standby?
>>> We send %s to tell pg_standby the standby_mode of the server which is
>>> calling it so it can decide how to act in each case.
>> That would work too, but it doesn't seem any simpler to me. On the contrary.
> 
> It would mean that pg_standby would act appropriately according to the
> setting of standby_mode. So you wouldn't need multiple examples of use,
> it would all just work whatever the setting of standby_mode. Nice simple
> entry in the docs.
> 
> We've said we need a script and pg_standby is it. Having a second
> script, pg_standby2, rather than adding something to the existing tools
> just seems confusing and easier to get wrong.
> 
> I'm happy to do the patch if you like.

Well, doesn't really seem that useful to me, but I won't object if you
want to do it.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com