Message-ID: <4B75533D.2000703@enterprisedb.com>
Date: Fri, 12 Feb 2010 15:10:21 +0200
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706)
MIME-Version: 1.0
To: Simon Riggs <simon@2ndQuadrant.com>
CC: Fujii Masao <masao.fujii@gmail.com>,
	Dimitri Fontaine <dfontaine@hi-media.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server  continuously
	retry restoring the next WAL
References: <20100127152751.3B2047541B9@cvs.postgresql.org>	
	<4B73F678.8070109@enterprisedb.com>
	<1265891248.7341.1346.camel@ebony>	
	<4B73FB99.4080403@enterprisedb.com>
	<1265893599.7341.1454.camel@ebony>	
	<877hqjc2kk.fsf@hi-media-techno.com>
	<1265896250.7341.1627.camel@ebony>	
	<4B740C6C.3010607@enterprisedb.com>
	<1265897834.7341.1714.camel@ebony>	
	<4B7412BE.5030605@enterprisedb.com>	
	<3f0b79eb1002112138n61a3258fg9986e50751d44ea0@mail.gmail.com>
	<1265979080.7341.3679.camel@ebony>
In-Reply-To: <1265979080.7341.3679.camel@ebony>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Simon Riggs wrote:
> In 8.4 it is pg_standby that was responsible for clearing down the
> archive, which is why I suggested using pg_standby for that again. I
> agree that will not work. The important thing is not pg_standby but that
> we have a valid mechanism for clearing down the archive.

Good point. When streaming from the master, the standby doesn't call
restore_command, and restore_command doesn't get a chance to clean up
old files.

> So I suggest that you have a new action that gets called after every
> checkpoint to clear down the archive. It will remove all files from the
> archive prior to %r. We can implement that as a sequence of unlink()s
> from within the server, or we can just call a script to do it. I prefer
> the latter approach. However we do it, we need something initiated by
> the server to maintain the archive and stop it from overflowing. 

+1

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com