Received: from maia.hub.org (unknown [200.46.208.211])
	by mail.postgresql.org (Postfix) with ESMTP id 657DF632D29
	for <pgsql-docs-postgresql.org@mail.postgresql.org>;
	Thu, 25 Feb 2010 07:03:56 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia,
	port 10024) with ESMTP id 88609-03 for
	<pgsql-docs-postgresql.org@mail.postgresql.org>;
	Thu, 25 Feb 2010 11:03:39 +0000 (UTC)
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6
Received: from exprod7og104.obsmtp.com (exprod7og104.obsmtp.com [64.18.2.161])
	by mail.postgresql.org (Postfix) with SMTP id EAF6C632D07
	for <pgsql-docs@postgresql.org>; Thu, 25 Feb 2010 07:03:44 -0400 (AST)
Received: from source ([209.85.219.215]) by exprod7ob104.postini.com
	([64.18.6.12]) with SMTP
	ID DSNKS4ZZDooD5OcPfcgSsu23WmkiGCUs5o0n@postini.com;
	Thu, 25 Feb 2010 03:03:44 PST
Received: by ewy7 with SMTP id 7so1350634ewy.29
	for <pgsql-docs@postgresql.org>; Thu, 25 Feb 2010 03:03:42 -0800 (PST)
Received: by 10.213.100.161 with SMTP id y33mr666605ebn.27.1267094498054;
	Thu, 25 Feb 2010 02:41:38 -0800 (PST)
Received: from ?192.168.1.117? ([88.195.103.165])
	by mx.google.com with ESMTPS id 16sm1364329ewy.3.2010.02.25.02.41.36
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Thu, 25 Feb 2010 02:41:37 -0800 (PST)
Message-ID: <4B8653DF.3000009@enterprisedb.com>
Date: Thu, 25 Feb 2010 12:41:35 +0200
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706)
MIME-Version: 1.0
To: Fujii Masao <masao.fujii@gmail.com>
CC: Thom Brown <thombrown@gmail.com>, pgsql-docs@postgresql.org
Subject: Re: Confusing link in streaming replication section
References: <bddc86151002101443t69d6e2e7rd6c76ea6287e6061@mail.gmail.com>	
	<3f0b79eb1002111757y3d11102n7fdfcee8f332f6d4@mail.gmail.com>	
	<bddc86151002120815m5b9e6922p90aba868b5dae9d7@mail.gmail.com>	
	<3f0b79eb1002241845p782c5e49v53a48be5aa67abf0@mail.gmail.com>	
	<bddc86151002250003r2c85958bsc47ebc0b5c7ed545@mail.gmail.com>	
	<3f0b79eb1002250020y81e9f44g54e3021edcaebdc3@mail.gmail.com>	
	<4B863FA6.90706@enterprisedb.com>
	<3f0b79eb1002250134g5e186d3dy3025af6fb08377d6@mail.gmail.com>
In-Reply-To: <3f0b79eb1002250134g5e186d3dy3025af6fb08377d6@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-1.509 tagged_above=-10 required=5 tests=AWL=-0.671,
	BAYES_00=-2.599, FS_REPLICA=1.041, SARE_SPEC_REPLICA=0.72
X-Spam-Level: 
X-Archive-Number: 201002/39
X-Sequence-Number: 5355

Fujii Masao wrote:
> On Thu, Feb 25, 2010 at 6:15 PM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
>> Yeah, it's not very clear as it is.
>>
>> How about this:
>>
>> --- a/doc/src/sgml/recovery-config.sgml
>> +++ b/doc/src/sgml/recovery-config.sgml
>> @@ -193,7 +193,8 @@ restore_command = 'copy "C:\\server\\archivedir\\%f"
>> "%p"'
>>         <listitem>
>>          <para>
>>           Specifies a connection string to be used for the standby server
>> -          to connect with the primary. This string is in the same format as
>> +          to connect with the primary. This string is in the format
>> +          accepted by the libpq <function>PQconnectdb</function> function,
>>           described in <xref linkend="libpq-connect">. If any option is
>>           unspecified in this string, then the corresponding environment
>>           variable (see <xref linkend="libpq-envars">) is checked. If the
> 
> The following description in the document about PQconnectdb() doesn't fit
> primary_conninfo because of restriction of readRecoveryCommandFile().
> 
> ---------------
> To write an empty value, or a value containing spaces,
> surround it with single quotes, e.g., keyword = 'a value'. Single quotes
> and backslashes within the value must be escaped with a backslash,
> i.e., \' and \\.
> ---------------

Hmm, so how does one escape quotes in recovery.conf? That would be valid
information, if readRecoveryCommandFile() didn't choke on quotes.

At some point we'll have to make the recovery.conf parsing smarter, if
only for consistency with postgresql.conf, or merge them completely...

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com