Message-ID: <4BAB5B9B.80203@enterprisedb.com>
Date: Thu, 25 Mar 2010 14:48:27 +0200
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706)
MIME-Version: 1.0
To: Fujii Masao <masao.fujii@gmail.com>
CC: Simon Riggs <simon@2ndquadrant.com>, Aidan Van Dyk <aidan@highrise.ca>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server 	continuously
	retry restoring the next WAL
References: <3f0b79eb1002092105r21e009d3v468496058ba04392@mail.gmail.com>	
	<20100211144204.GC14128@oak.highrise.ca>	
	<4B743E7D.5070603@enterprisedb.com>	
	<3f0b79eb1002180337t1fab1395ve3491256672af15f@mail.gmail.com>	
	<4BA0B079.3050301@enterprisedb.com>	
	<3f0b79eb1003180727g7877743eq81274e014fe70a49@mail.gmail.com>	
	<1268988724.3556.3.camel@ebony>
	<4BA361E4.7020309@enterprisedb.com>	
	<3f0b79eb1003230017v16f4ecbeyc20e75beeffe8f1c@mail.gmail.com>	
	<4BAA060A.2020000@enterprisedb.com>
	<3f0b79eb1003240620h209a0a40ud2063728b5db31a6@mail.gmail.com>
In-Reply-To: <3f0b79eb1003240620h209a0a40ud2063728b5db31a6@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Fujii Masao wrote:
>> sources &= ~failedSources;
>> failedSources |= readSource;
> 
> The above lines in XLogPageRead() seem not to be required in normal
> recovery case (i.e., standby_mode = off). So how about the attached
> patch?
>
> *** 9050,9056 **** next_record_is_invalid:
> --- 9047,9056 ----
>   	readSource = 0;
>   
>   	if (StandbyMode)
> + 	{
> + 		failedSources |= readSource;
>   		goto retry;
> + 	}
>   	else
>   		return false;

That doesn't work because readSource is cleared above. But yeah,
failedSources is not needed in archive recovery, so that line can be
removed.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com