Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id E088863522E for ; Tue, 30 Mar 2010 14:14:50 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 43569-02-7 for ; Tue, 30 Mar 2010 17:14:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from exprod7og101.obsmtp.com (exprod7og101.obsmtp.com [64.18.2.155]) by mail.postgresql.org (Postfix) with SMTP id AC5006355F8 for ; Tue, 30 Mar 2010 13:29:01 -0300 (ADT) Received: from source ([74.125.78.26]) by exprod7ob101.postini.com ([64.18.6.12]) with SMTP ID DSNKS7Imy666NrG6D0uu1v26mTkEuXY/sYOn@postini.com; Tue, 30 Mar 2010 09:29:01 PDT Received: by ey-out-2122.google.com with SMTP id 4so978330eyf.21 for ; Tue, 30 Mar 2010 09:28:56 -0700 (PDT) Received: by 10.213.95.129 with SMTP id d1mr3639966ebn.13.1269966529936; Tue, 30 Mar 2010 09:28:49 -0700 (PDT) Received: from [192.168.1.117] (dsl-hkibrasgw2-ff67c300-165.dhcp.inet.fi [88.195.103.165]) by mx.google.com with ESMTPS id 13sm3084559ewy.9.2010.03.30.09.28.41 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 30 Mar 2010 09:28:43 -0700 (PDT) Message-ID: <4BB226AC.4020205@enterprisedb.com> Date: Tue, 30 Mar 2010 19:28:28 +0300 From: Heikki Linnakangas Organization: EnterpriseDB User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706) MIME-Version: 1.0 To: Fujii Masao CC: Simon Riggs , Aidan Van Dyk , PostgreSQL-development Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL References: <3f0b79eb1002092105r21e009d3v468496058ba04392@mail.gmail.com> <4BA0B079.3050301@enterprisedb.com> <3f0b79eb1003180727g7877743eq81274e014fe70a49@mail.gmail.com> <1268988724.3556.3.camel@ebony> <4BA361E4.7020309@enterprisedb.com> <3f0b79eb1003230017v16f4ecbeyc20e75beeffe8f1c@mail.gmail.com> <4BAA060A.2020000@enterprisedb.com> <3f0b79eb1003240620h209a0a40ud2063728b5db31a6@mail.gmail.com> <3f0b79eb1003240636y6ba3d739idc4555f88c98e32e@mail.gmail.com> <4BAB5D4E.4000009@enterprisedb.com> <3f0b79eb1003252224u9b91cc4la75547c6a2610ffc@mail.gmail.com> In-Reply-To: <3f0b79eb1003252224u9b91cc4la75547c6a2610ffc@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201003/1230 X-Sequence-Number: 160006 Fujii Masao wrote: >> * Small code changes to handling of failedSources, inspired by your >> comment. No change in functionality. >> >> This is also available in my git repository at >> git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges" > > I looked the patch and was not able to find any big problems until now. > The attached small patch fixes the typo. Thanks. Committed with that typo-fix, and I also added a comment explaining how failedSources and retrying XLogPageRead() works. I'm now happy with the standby mode logic. It was a bigger struggle than I anticipated back in January/February, I hope others now find it intuitive as well. I'm going to work on the documentation of this, along the lines of the draft I posted last week. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com