pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #5814: documentation bug
10+ messages / 6 participants
[nested] [flat]
* BUG #5814: documentation bug
@ 2011-01-05 13:04 Antje Petersen <antje.petersen@desy.de>
0 siblings, 2 replies; 10+ messages in thread
From: Antje Petersen @ 2011-01-05 13:04 UTC (permalink / raw)
To: pgsql-bugs@postgresql.org
The following bug has been logged online:
Bug reference: 5814
Logged by: Antje Petersen
Email address: antje.petersen@desy.de
PostgreSQL version: 8.1.21
Operating system: Scientific Linux 5
Description: documentation bug
Details:
According to the documentation
createuser --no-superuser and
createuser --no-createrole is the default.
This is not true. The default is to be asked
Shall the new role be a superuser? (y/n)
Shall the new role be allowed to create more new roles? (y/n)
Cheers,
antje
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: BUG #5814: documentation bug
@ 2011-01-08 03:19 Josh Kupershmidt <schmiddy@gmail.com>
parent: Antje Petersen <antje.petersen@desy.de>
1 sibling, 1 reply; 10+ messages in thread
From: Josh Kupershmidt @ 2011-01-08 03:19 UTC (permalink / raw)
To: pgsql-docs; +Cc: Antje Petersen <antje.petersen@desy.de>
[moving to pgsql-docs]
On Wed, Jan 5, 2011 at 8:04 AM, Antje Petersen <antje.petersen@desy.de> wrote:
> According to the documentation
> createuser --no-superuser and
> createuser --no-createrole is the default.
> This is not true. The default is to be asked
> Shall the new role be a superuser? (y/n)
> Shall the new role be allowed to create more new roles? (y/n)
I agree that the incorrect claims about defaults for --superuser,
--createrole, and --createdb should be gotten rid of, since there are
no defaults for these options and createuser will force you to answer
Y or N for these options if you didn't specify on the command line.
Simple doc patch attached. I think the "Examples" section demonstrates
that createuser will prompt for this information without having to
belabor this point in the doc.
Josh
Attachments:
createuser_defaults.patch (text/x-patch, 857B) download
diff --git a/doc/src/sgml/ref/createuser.sgml b/doc/src/sgml/ref/createuser.sgml
index 08c82e0..fbc184f 100644
--- a/doc/src/sgml/ref/createuser.sgml
+++ b/doc/src/sgml/ref/createuser.sgml
@@ -103,7 +103,6 @@ PostgreSQL documentation
<listitem>
<para>
The new user will not be allowed to create databases.
- This is the default.
</para>
</listitem>
</varlistentry>
@@ -217,7 +216,6 @@ PostgreSQL documentation
<listitem>
<para>
The new user will not be allowed to create new roles.
- This is the default.
</para>
</listitem>
</varlistentry>
@@ -238,7 +236,6 @@ PostgreSQL documentation
<listitem>
<para>
The new user will not be a superuser.
- This is the default.
</para>
</listitem>
</varlistentry>
* Re: [BUGS] BUG #5814: documentation bug
@ 2011-01-08 11:14 Robert Haas <robertmhaas@gmail.com>
parent: Josh Kupershmidt <schmiddy@gmail.com>
0 siblings, 0 replies; 10+ messages in thread
From: Robert Haas @ 2011-01-08 11:14 UTC (permalink / raw)
To: Josh Kupershmidt <schmiddy@gmail.com>; +Cc: pgsql-docs; Antje Petersen <antje.petersen@desy.de>
On Fri, Jan 7, 2011 at 10:19 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
> [moving to pgsql-docs]
>
> On Wed, Jan 5, 2011 at 8:04 AM, Antje Petersen <antje.petersen@desy.de> wrote:
>> According to the documentation
>> createuser --no-superuser and
>> createuser --no-createrole is the default.
>> This is not true. The default is to be asked
>> Shall the new role be a superuser? (y/n)
>> Shall the new role be allowed to create more new roles? (y/n)
>
> I agree that the incorrect claims about defaults for --superuser,
> --createrole, and --createdb should be gotten rid of, since there are
> no defaults for these options and createuser will force you to answer
> Y or N for these options if you didn't specify on the command line.
>
> Simple doc patch attached. I think the "Examples" section demonstrates
> that createuser will prompt for this information without having to
> belabor this point in the doc.
Committed to master and REL9_0_STABLE.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: BUG #5814: documentation bug
@ 2011-03-11 03:45 Bruce Momjian <bruce@momjian.us>
parent: Antje Petersen <antje.petersen@desy.de>
1 sibling, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2011-03-11 03:45 UTC (permalink / raw)
To: Antje Petersen <antje.petersen@desy.de>; +Cc: pgsql-bugs@postgresql.org
Antje Petersen wrote:
>
> The following bug has been logged online:
>
> Bug reference: 5814
> Logged by: Antje Petersen
> Email address: antje.petersen@desy.de
> PostgreSQL version: 8.1.21
> Operating system: Scientific Linux 5
> Description: documentation bug
> Details:
>
> According to the documentation
> createuser --no-superuser and
> createuser --no-createrole is the default.
> This is not true. The default is to be asked
> Shall the new role be a superuser? (y/n)
> Shall the new role be allowed to create more new roles? (y/n)
Sorry for the late reply. If you press "enter", "no" is the default.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: BUG #5814: documentation bug
@ 2011-03-11 14:33 Robert Haas <robertmhaas@gmail.com>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 10+ messages in thread
From: Robert Haas @ 2011-03-11 14:33 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Antje Petersen <antje.petersen@desy.de>; pgsql-bugs@postgresql.org
On Thu, Mar 10, 2011 at 10:45 PM, Bruce Momjian <bruce@momjian.us> wrote:
> Antje Petersen wrote:
>>
>> The following bug has been logged online:
>>
>> Bug reference: 5814
>> Logged by: Antje Petersen
>> Email address: antje.petersen@desy.de
>> PostgreSQL version: 8.1.21
>> Operating system: Scientific Linux 5
>> Description: documentation bug
>> Details:
>>
>> According to the documentation
>> createuser --no-superuser and
>> createuser --no-createrole is the default.
>> This is not true. The default is to be asked
>> Shall the new role be a superuser? (y/n)
>> Shall the new role be allowed to create more new roles? (y/n)
>
> Sorry for the late reply. If you press "enter", "no" is the default.
That's a lame answer. Surely this is a documentation bug.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: BUG #5814: documentation bug
@ 2011-03-11 14:44 Bruce Momjian <bruce@momjian.us>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 2 replies; 10+ messages in thread
From: Bruce Momjian @ 2011-03-11 14:44 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: Antje Petersen <antje.petersen@desy.de>; pgsql-bugs@postgresql.org
Robert Haas wrote:
> On Thu, Mar 10, 2011 at 10:45 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > Antje Petersen wrote:
> >>
> >> The following bug has been logged online:
> >>
> >> Bug reference: ? ? ?5814
> >> Logged by: ? ? ? ? ?Antje Petersen
> >> Email address: ? ? ?antje.petersen@desy.de
> >> PostgreSQL version: 8.1.21
> >> Operating system: ? Scientific Linux 5
> >> Description: ? ? ? ?documentation bug
> >> Details:
> >>
> >> According to the documentation
> >> createuser --no-superuser and
> >> createuser --no-createrole is the default.
> >> This is not true. The default is to be asked
> >> Shall the new role be a superuser? (y/n)
> >> Shall the new role be allowed to create more new roles? (y/n)
> >
> > Sorry for the late reply. ?If you press "enter", "no" is the default.
>
> That's a lame answer. Surely this is a documentation bug.
Well, what do you suggest? I see no other way to specify the default
for pressing <ENTER>. I know I just press <ENTER> at those prompts.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: BUG #5814: documentation bug
@ 2011-03-11 14:56 Alvaro Herrera <alvherre@commandprompt.com>
parent: Bruce Momjian <bruce@momjian.us>
1 sibling, 1 reply; 10+ messages in thread
From: Alvaro Herrera @ 2011-03-11 14:56 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Robert Haas <robertmhaas@gmail.com>; Antje Petersen <antje.petersen@desy.de>; pgsql-bugs <pgsql-bugs@postgresql.org>
Excerpts from Bruce Momjian's message of vie mar 11 11:44:52 -0300 2011:
> Robert Haas wrote:
> > On Thu, Mar 10, 2011 at 10:45 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > > Antje Petersen wrote:
> > >>
> > >> The following bug has been logged online:
> > >>
> > >> According to the documentation
> > >> createuser --no-superuser and
> > >> createuser --no-createrole is the default.
> > >> This is not true. The default is to be asked
> > >> Shall the new role be a superuser? (y/n)
> > >> Shall the new role be allowed to create more new roles? (y/n)
> > >
> > > Sorry for the late reply. ?If you press "enter", "no" is the default.
> >
> > That's a lame answer. Surely this is a documentation bug.
>
> Well, what do you suggest? I see no other way to specify the default
> for pressing <ENTER>. I know I just press <ENTER> at those prompts.
He's saying that the documentation should say "if no options are passed,
you will be asked".
While at it, I think the default option should be capitalized:
Shall the new role be allowed to create more new roles? (y/N)
That way, the user knows what will happen, without having to look it up
in the docs. This capitalization of the default option is pretty common
nowadays.
--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: BUG #5814: documentation bug
@ 2011-03-11 14:56 tushar <tushar.ahuja@enterprisedb.com>
parent: Bruce Momjian <bruce@momjian.us>
1 sibling, 0 replies; 10+ messages in thread
From: tushar @ 2011-03-11 14:56 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Robert Haas <robertmhaas@gmail.com>; Antje Petersen <antje.petersen@desy.de>; pgsql-bugs@postgresql.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Bruce Momjian wrote:
> Well, what do you suggest? I see no other way to specify the default
> for pressing <ENTER>. I know I just press <ENTER> at those prompts.
>
[root@tushar bin]# ./createuser -p 5438
Enter name of role to add: test
Shall the new role be a superuser? (y/n)
Please answer "y" or "n".
Shall the new role be a superuser? (y/n)
even if i just <<enter>> it is still asking me to enter 'y' or 'n'
i m using pg9.0 beta3
[root@tushar bin]# ./psql postgres -U postgres -p 5438
Password for user postgres:
psql (9.0beta3)
Type "help" for help.
postgres=#
i think it should show like this :-(if n is the default)
[root@tushar bin]# ./createuser -p 5438
Enter name of role to add: test
Shall the new role be a superuser? (y/N)
Shall the new role be allowed to create more new roles? (y/N)
but don't know how it is behaving in PG 8.1 (as this issue reported against that version)
- --
regards,tushar
Lead QA Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Mobile: +91-99227433-47
This e-mail message (and any attachment) is intended for the use of
the individual or entity to whom it is addressed. This message
contains information from EnterpriseDB Corporation that may be
privileged, confidential, or exempt from disclosure under applicable
law. If you are not the intended recipient or authorized to receive
this for the intended recipient, any use, dissemination, distribution,
retention, archiving, or copying of this communication is strictly
prohibited. If you have received this e-mail in error, please notify
the sender immediately by reply e-mail and delete this message
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQFNejgVfQNodY2PIRoRAtXVAJ9xa6OKelV5dqmwW+bBTSFwhtxsNACgjtjx
F0MwcsLqhrC8gD+GOQNgpgs=
=loHA
-----END PGP SIGNATURE-----
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: BUG #5814: documentation bug
@ 2011-03-11 15:05 Bruce Momjian <bruce@momjian.us>
parent: Alvaro Herrera <alvherre@commandprompt.com>
0 siblings, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2011-03-11 15:05 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@commandprompt.com>; +Cc: Robert Haas <robertmhaas@gmail.com>; Antje Petersen <antje.petersen@desy.de>; pgsql-bugs <pgsql-bugs@postgresql.org>
Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of vie mar 11 11:44:52 -0300 2011:
> > Robert Haas wrote:
> > > On Thu, Mar 10, 2011 at 10:45 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > > > Antje Petersen wrote:
> > > >>
> > > >> The following bug has been logged online:
> > > >>
>
> > > >> According to the documentation
> > > >> createuser --no-superuser and
> > > >> createuser --no-createrole is the default.
> > > >> This is not true. The default is to be asked
> > > >> Shall the new role be a superuser? (y/n)
> > > >> Shall the new role be allowed to create more new roles? (y/n)
> > > >
> > > > Sorry for the late reply. ?If you press "enter", "no" is the default.
> > >
> > > That's a lame answer. Surely this is a documentation bug.
> >
> > Well, what do you suggest? I see no other way to specify the default
> > for pressing <ENTER>. I know I just press <ENTER> at those prompts.
>
> He's saying that the documentation should say "if no options are passed,
> you will be asked".
>
> While at it, I think the default option should be capitalized:
> Shall the new role be allowed to create more new roles? (y/N)
> That way, the user knows what will happen, without having to look it up
> in the docs. This capitalization of the default option is pretty common
> nowadays.
Oops, I was wrong. There is no default. It keeps prompting if I press
<ENTER>.
Also, it seems this was addressed in January:
commit af84bee43e356866dc46c95ae5bf77996a8237ff
Author: Robert Haas <rhaas@postgresql.org>
Date: Sat Jan 8 06:12:05 2011 -0500
Remove bogus claims regarding createuser defaults.
Josh Kupershmidt
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: BUG #5814: documentation bug
@ 2011-03-11 16:30 Robert Haas <robertmhaas@gmail.com>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Robert Haas @ 2011-03-11 16:30 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Alvaro Herrera <alvherre@commandprompt.com>; Antje Petersen <antje.petersen@desy.de>; pgsql-bugs <pgsql-bugs@postgresql.org>
On Fri, Mar 11, 2011 at 10:05 AM, Bruce Momjian <bruce@momjian.us> wrote:
> Also, it seems this was addressed in January:
>
> commit af84bee43e356866dc46c95ae5bf77996a8237ff
> Author: Robert Haas <rhaas@postgresql.org>
> Date: Sat Jan 8 06:12:05 2011 -0500
>
> Remove bogus claims regarding createuser defaults.
>
> Josh Kupershmidt
Ah, so it was. I probably should have remembered that, considering
that I was the one who committed the patch. Thanks for following up;
sounds like there is nothing further we need to do here.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2011-03-11 16:30 UTC | newest]
Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2011-01-05 13:04 BUG #5814: documentation bug Antje Petersen <antje.petersen@desy.de>
2011-01-08 03:19 ` Josh Kupershmidt <schmiddy@gmail.com>
2011-01-08 11:14 ` Robert Haas <robertmhaas@gmail.com>
2011-03-11 03:45 ` Bruce Momjian <bruce@momjian.us>
2011-03-11 14:33 ` Robert Haas <robertmhaas@gmail.com>
2011-03-11 14:44 ` Bruce Momjian <bruce@momjian.us>
2011-03-11 14:56 ` Alvaro Herrera <alvherre@commandprompt.com>
2011-03-11 15:05 ` Bruce Momjian <bruce@momjian.us>
2011-03-11 16:30 ` Robert Haas <robertmhaas@gmail.com>
2011-03-11 14:56 ` tushar <tushar.ahuja@enterprisedb.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox