Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 775CAB5DBC8 for ; Fri, 17 Jun 2011 08:24:20 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 23517-10 for ; Fri, 17 Jun 2011 11:24:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pv0-f174.google.com (mail-pv0-f174.google.com [74.125.83.174]) by mail.postgresql.org (Postfix) with ESMTP id 31000B5D803 for ; Fri, 17 Jun 2011 08:24:14 -0300 (ADT) Received: by pvg12 with SMTP id 12so1732122pvg.19 for ; Fri, 17 Jun 2011 04:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=YBwyf+9YDDfZRYcDViWUaQpdWUE48nB8nFKByFvrKvw=; b=tJGWmBAkS+Gwbz2Tz62Vi9njvBdoro419FdkjejiHUMzcy1meVPnzQeQFEF01xsfoY FKdh9nMAZqTA3rFjS54Q/xYiD7EmGT9hLBqy3XPIEXIcJvP2aj5m21Un+OVkAS2FqlPU BgG0yRtv3vm2qF+Smu8pyUuwcRM/Ibuk5fl00= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=UMb9LAy3kcJmfHRQ08xPbZ1c95glgetN7nX593nCLPM1peudjJFy8x3MLiZ14foArQ 4fRlQ4gG8e6iCu1oTDxLUlGKeTVSrZYyyab3HnAXcdwK0ddcvteR5BchyRGEcTI3VAOh UaJOB1cb7iyfMsbeqC5ICIFqaFA29nPOF/HgA= Received: by 10.142.214.2 with SMTP id m2mr316527wfg.330.1308309853617; Fri, 17 Jun 2011 04:24:13 -0700 (PDT) Received: from [192.168.1.120] ([61.199.203.168]) by mx.google.com with ESMTPS id k2sm2696787wfe.3.2011.06.17.04.24.11 (version=SSLv3 cipher=OTHER); Fri, 17 Jun 2011 04:24:12 -0700 (PDT) Message-ID: <4DFB3969.7090306@gmail.com> Date: Fri, 17 Jun 2011 20:24:25 +0900 From: Shigeru Hanada User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Joshua Berkus CC: pgsql-docs@postgresql.org Subject: Re: File_FDW with example References: <1054372046.268838.1308273696804.JavaMail.root@mail-1.01.com> <4DFB36D7.3070208@gmail.com> In-Reply-To: <4DFB36D7.3070208@gmail.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.898 tagged_above=-5 required=5 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, RFC_ABUSE_POST=0.001 X-Spam-Level: X-Archive-Number: 201106/79 X-Sequence-Number: 6853 (2011/06/17 20:13), Shigeru Hanada wrote: > I examined the example, and found some points which should be corrected: > > - Some lines are over 80 columns. > - CREATE EXTENSION file_fdw also creates default FOREIGN DATA WRAPPER > file_fdw, so no need to create FOREIGN DATA WRAPPER explicitly. Oops, I forgot an important one. - needs to be added after Regards, -- Shigeru Hanada