Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id 870A9B5DBE1 for ; Thu, 30 Jun 2011 07:31:36 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 67193-02 for ; Thu, 30 Jun 2011 10:31:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pz0-f46.google.com (mail-pz0-f46.google.com [209.85.210.46]) by mail.postgresql.org (Postfix) with ESMTP id E1A98B5DBDA for ; Thu, 30 Jun 2011 07:31:29 -0300 (ADT) Received: by pzk9 with SMTP id 9so1597493pzk.19 for ; Thu, 30 Jun 2011 03:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=zAetja7XXlna3k443/fqQuKkrkxEM/T3pQhszi9T4YQ=; b=w32IHXiAbFecu4yOb5N/YuBsnqRsWVXIh3bbFHm6n+d+81FLbGhk0PUfp+4n8DwB4K +N2ohfCQgb5a/ZXariV/Hx4ZT4wOrNDCgszgJftG4foHBBwiNyouzSXo1i2TzbO8Fvrq Acuz/K+d5lsgZHaFgJGAF0zF5rHKG+ULJLNIA= Received: by 10.142.201.11 with SMTP id y11mr858195wff.179.1309429888129; Thu, 30 Jun 2011 03:31:28 -0700 (PDT) Received: from [192.168.1.120] ([61.199.203.168]) by mx.google.com with ESMTPS id l10sm1383572wfk.21.2011.06.30.03.31.26 (version=SSLv3 cipher=OTHER); Thu, 30 Jun 2011 03:31:27 -0700 (PDT) Message-ID: <4E0C50A0.9070109@gmail.com> Date: Thu, 30 Jun 2011 19:32:00 +0900 From: Shigeru Hanada User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: pgsql-docs@postgresql.org Subject: Improve FDW document (for 9.1) Content-Type: multipart/mixed; boundary="------------040300070000060205060703" X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.889 tagged_above=-5 required=5 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, T_TO_NO_BRKTS_FREEMAIL=0.01 X-Spam-Level: X-Archive-Number: 201106/93 X-Sequence-Number: 6867 This is a multi-part message in MIME format. --------------040300070000060205060703 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Hi, During reading Albe's patch for FDW validator attached to "Bug in SQL/MED?" posted to pgsql-hackers[1], I noticed that neither ALTER commands nor USER MAPPING is mentioned in the description of FDW validator in "Writing A Foreign Data Wrapper"[2]. The validator function is also called for ALTER commands and USER MAPPING manipulation, if any FDW option remains. FYI, Albe's patch is for calling validator even if no option remains. [1]http://archives.postgresql.org/pgsql-hackers/2011-06/msg02230.php [2]http://developer.postgresql.org/pgdocs/postgres/fdwhandler.html Please find attached a patch which adds a mention of ALTER and USER MAPPING. Regards, -- Shigeru Hanada --------------040300070000060205060703 Content-Type: text/plain; name="fdw_doc.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fdw_doc.patch" ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9mZHdoYW5kbGVyLnNnbWwgYi9kb2Mvc3JjL3Nn bWwvZmR3aGFuZGxlci5zZ21sCmluZGV4IGM4YWU4NjEuLmMxN2M1NDAgMTAwNjQ0Ci0tLSBh L2RvYy9zcmMvc2dtbC9mZHdoYW5kbGVyLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2Zkd2hh bmRsZXIuc2dtbApAQCAtMzksMTMgKzM5LDE4IEBACiAKICAgIDxwYXJhPgogICAgIFRoZSB2 YWxpZGF0b3IgZnVuY3Rpb24gaXMgcmVzcG9uc2libGUgZm9yIHZhbGlkYXRpbmcgb3B0aW9u cyBnaXZlbiBpbiB0aGUKLSAgICA8Y29tbWFuZD5DUkVBVEUgRk9SRUlHTiBEQVRBIFdSQVBQ RVI8L2NvbW1hbmQ+LCA8Y29tbWFuZD5DUkVBVEUKLSAgICBTRVJWRVI8L2NvbW1hbmQ+IGFu ZCA8Y29tbWFuZD5DUkVBVEUgRk9SRUlHTiBUQUJMRTwvY29tbWFuZD4gY29tbWFuZHMuCisg ICAgPGNvbW1hbmQ+Q1JFQVRFPC9jb21tYW5kPiBhbmQgPGNvbW1hbmQ+QUxURVI8L2NvbW1h bmQ+IGNvbW1hbmRzIGZvcgorICAgIDxsaXRlcmFsPkZPUkVJR04gREFUQSBXUkFQUEVSPC8+ LCA8bGl0ZXJhbD5TRVJWRVI8Lz4sCisgICAgPGxpdGVyYWw+VVNFUiBNQVBQSU5HPC8+IGFu ZCA8bGl0ZXJhbD5GT1JFSUdOIFRBQkxFPC8+LiAgVG8gbWFrZSBpdAorICAgIHBvc3NpYmxl IHRvIGVuZm9yY2UgcmVxdWlyZWQgb3B0aW9uLCB0aGUgdmFsaWRhdG9yIGZ1bmN0aW9uIGlz IGNhbGxlZCBmb3IKKyAgICBldmVyeSBzdWNoIGNvbW1hbmQgZXZlbiBpZiB0aGUgb3B0aW9u IGxpc3Qgd2FzIGVtcHR5IGFzIGEgcmVzdWx0IG9mCisgICAgZHJvcHBpbmcgYWxsIG9wdGlv bnMuCiAgICAgVGhlIHZhbGlkYXRvciBmdW5jdGlvbiBtdXN0IGJlIHJlZ2lzdGVyZWQgYXMg dGFraW5nIHR3byBhcmd1bWVudHMsIGEgdGV4dAogICAgIGFycmF5IGNvbnRhaW5pbmcgdGhl IG9wdGlvbnMgdG8gYmUgdmFsaWRhdGVkLCBhbmQgYW4gT0lEIHJlcHJlc2VudGluZyB0aGUK ICAgICB0eXBlIG9mIG9iamVjdCB0aGUgb3B0aW9ucyBhcmUgYXNzb2NpYXRlZCB3aXRoIChp biB0aGUgZm9ybSBvZiB0aGUgT0lECiAgICAgb2YgdGhlIHN5c3RlbSBjYXRhbG9nIHRoZSBv YmplY3Qgd291bGQgYmUgc3RvcmVkIGluKS4gIElmIG5vIHZhbGlkYXRvcgotICAgIGZ1bmN0 aW9uIGlzIHN1cHBsaWVkLCB0aGUgb3B0aW9ucyBhcmUgbm90IGNoZWNrZWQgYXQgb2JqZWN0 IGNyZWF0aW9uIHRpbWUuCisgICAgZnVuY3Rpb24gaXMgc3VwcGxpZWQsIHRoZSBvcHRpb25z IGFyZSBub3QgY2hlY2tlZCBhdCBvYmplY3QgY3JlYXRpb24gdGltZQorICAgIG9yIG9iamVj dCBhbHRlcmF0aW9uIHRpbWUuCiAgICA8L3BhcmE+CiAKICAgIDxwYXJhPgo= --------------040300070000060205060703--